London | May2025 | Fatima Z Belkedari | Module Structuring and Testing Data | Sprint 1#574
London | May2025 | Fatima Z Belkedari | Module Structuring and Testing Data | Sprint 1#574Farah-Stu wants to merge 18 commits intoCodeYourFuture:mainfrom
Conversation
Farah-Stu
added
the
Needs Review
Farah-Stu
changed the title
LonMcGregor
added
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good answers on this sprint. I have left a few comments for you to answer to make sure that you fully understand everything.
There was a problem hiding this comment.
Can you explain briefly why you made this change?
There was a problem hiding this comment.
Good answers. From a) I think you've got most of them, but you might want to re-check what you are counting.
There was a problem hiding this comment.
a) I think you are missing some declarations
b) You identify (movieLength - remainingSeconds /60;) as a function call - what is this calling? Are you sure there are 4 function calls
c) Are you sure this will be hours with minutes remaining? Remember what the original input of movieLength represents.
d) Good answer
e) Can you think of any values for movieLength where the code will not work properly?
LonMcGregor
added
Reviewed
Farah-Stu
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Thanks for making the changes. You can complete this sprint now
| //e) the variable result represents the totalHours,remainingMinutes and remainingSeconds. A better name could be displayTime. | ||
| //f)Technically, it does handle the codes using the correct format that is HH:MM:SS | ||
| // for example, if the movieLength is 500 seconds, the format will still be displayed correctly as 0:8:20.But if we use a negative number, it will | ||
| // mess up the format. |
| //a) There are 4 function calls.For instance:Number(carPrice.replaceAll(",", "")); | ||
| // Number(priceAfterOneYear.replaceAll("," ,"")); | ||
| //umber(priceAfterOneYear.replaceAll("," ,"")); | ||
| // console.log(`The percentage change is ${percentageChange}`); |
There was a problem hiding this comment.
Good work fixing the error in this file. You identified the lines which all have function calls.
LonMcGregor
removed
Needs Review
LonMcGregor
added
the
Complete
|
Thank you for taking the time to review my work.I really appreciate the feedback. |
3 participants
Learners, PR Template
Self checklist
Changelist
Implement courseWork exercises Sprint1
Questions
Ask any questions you have for your reviewer.