Skip to content

London | ITP-May-2025 | Mo Muchunu | Module-Structuring-and-Testing-Data | Sprint 3 #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mo-Muchunu wants to merge 30 commits into from
Closed

London | ITP-May-2025 | Mo Muchunu | Module-Structuring-and-Testing-Data | Sprint 3 #585

Mo-Muchunu wants to merge 30 commits into from

Conversation

@Mo-Muchunu
Copy link

@Mo-Muchunu Mo-Muchunu commented Jun 21, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Rewrote existing assertion tests using Jest for improved readability and maintainability.

  • Completed step-by-step implementation of functions, building and methodically assessing each test case.

  • Used VSCode’s built-in test runner, 'npm test' to run and verify test suites efficiently.

  • Applied Jest’s testing framework to replace 'console.assert' and custom helpers.

Questions

Ask any questions you have for your reviewer.

Mo-Muchunu added 13 commits June 19, 2025 07:37
@Mo-Muchunu
Added code and additional test cases to 'getAngleType'
3a9bbd2
@Mo-Muchunu
Implemented isProperFraction function with additional test cases
c66cb17
@Mo-Muchunu
Implement getCardValue function with various tests for card ranks
db99726
@Mo-Muchunu
Replaced code with completed 'getAngleType' function
dc3cb3b
@Mo-Muchunu
Replaced comments with test cases including clear descriptions
33f3f2f
@Mo-Muchunu
Added 'isProperFraction' code and decriptive test cases
b4ea116
@Mo-Muchunu
Wrote unit tests for 'getCardValue' function covering all card types
4b0860c
@Mo-Muchunu
Implement getOrdinalNumber to handle standard and special ordinal cases
00857ed
@Mo-Muchunu
Updated 'getOrdinalNumber' to return '0th' for zero and 'Invalid inpu…
efb6a75 
…t' for negative numbers
@Mo-Muchunu
Added comprehensive test cases for 'getOrdinalNumber' function
1049303
@Mo-Muchunu
Implemented 'repeat' function with negative count check and comprehen…
0a80b52 
…sive tests
@Mo-Muchunu
Implemented countChar function with tests for multiple and zero occur…
d7a23f6 
…rences
@Mo-Muchunu
Implemented 'countChar' function with tests for multiple and zero occ…
193bea4 
…urrences
@Mo-Muchunu Mo-Muchunu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 21, 2025
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2025
cjyuan
cjyuan reviewed Jul 4, 2025
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 4, 2025
@Mo-Muchunu Mo-Muchunu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 7, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 7, 2025

Changes look good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2025
@Mo-Muchunu
Copy link
Author

Mo-Muchunu commented Jul 7, 2025

Changes look good. Well done!

Thank you CJ!

@Mo-Muchunu Mo-Muchunu mentioned this pull request Jul 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mo-Muchunu @cjyuan @illicitonion