London | ITP-May-2025 | Adnaan Abo | Module Structuring and Testing Data Sprint-3#599
Closed
AdnaanA wants to merge 18 commits intoCodeYourFuture:to-be-deleted-coursework/sprint-3from
Closed
Conversation
modified: Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
AdnaanA
added
the
Needs Review
modified: Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js modified: Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js modified: Sprint-3/3-mandatory-practice/implement/repeat.js modified: Sprint-3/3-mandatory-practice/implement/repeat.test.js
modified: Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
AdnanGondal
added
Review in progress
AdnanGondal
reviewed
Jul 12, 2025
AdnanGondal
left a comment
AdnanGondal
left a comment
There was a problem hiding this comment.
The solution looks good - marking as complete.
Just a small piece of feedback: I can see you are using a lot of comments in your functions. Take a read of these pages to see why adding too many comments is not always a good idea:
- https://refactoring.guru/smells/comments
- https://dev.to/alisamir/understanding-clean-code-comments-1ahi
Essentially - your code should be self-documenting, and comments added only when necessary.
AdnanGondal
added
Complete
illicitonion
deleted the branch
CodeYourFuture:to-be-deleted-coursework/sprint-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Briefly explain your PR.
Sprint-3 coursework with updated functions and test completion, and bug fixes.
Questions
Ask any questions you have for your reviewer.