West Midland | ITP-May-2025 | Saleh Yousef | Module-Structuring-and-Testing-Data | sprint 3 #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: prep/example.js
… checks in isProperFraction tests
…date tests for accuracy; complete getAngleType function and enhance test cases for clarity and coverage.
…test cases for negative fractions and equal numerator/denominator scenarios.
…s in a string; add tests for various scenarios including no occurrences. Implement getOrdinalNumber function to return correct ordinal representations; enhance tests for multiple cases including special teen cases.
SalehOumar
added
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 4, 2025
Comment on lines
2
to
6
| if (card === "A") return 11; | ||
| if (["K", "Q", "J", "10"].includes(card)) return 10; | ||
| const num = Number(card); | ||
| if (num >= 2 && num <= 9 && card === num.toString()) return num; | ||
| throw new Error("Invalid card rank."); |
Contributor
There was a problem hiding this comment.
Can this function pass all the tests in Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js?
Author
There was a problem hiding this comment.
Previously it wasn’t - now I’ve simplified the getCardValue function to extract the rank using slice(0, -1), and cleaned up the logic to handle each valid case cleary.
Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Outdated
Show resolved
Hide resolved
cjyuan
added
Reviewed
SalehOumar
added
Needs Review
cjyuan
reviewed
Jul 6, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
All the other changes look good.
Comment on lines
6
to
7
| const num = Number(rank); | ||
| if (num >= 2 && num <= 9) return num; |
Contributor
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "00_02".
Does your function return the value you expected from each of the following function calls?
getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("00_02♠");
Author
There was a problem hiding this comment.
fixed, the earlier function had loose logic.
Comment on lines
8
to
14
| test("should return 5 for Five of Hearts", () => { | ||
| expect(getCardValue("5♥")).toEqual(5); | ||
| expect(getCardValue("3♣")).toEqual(3); | ||
| expect(getCardValue("4♦")).toEqual(4); | ||
|
|
||
|
|
||
| }); |
Contributor
There was a problem hiding this comment.
The test description does not quite match the values being tested.
Author
There was a problem hiding this comment.
I’ve fixed the description so it matches the actual test values now. Thank you
cjyuan
added
Reviewed
SalehOumar
added
Needs Review
Contributor
|
Changes look good. Well done! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed sprint 3 coursework
Questions
Ask any questions you have for your reviewer.