Birmingham | 25-ITP-Sep | Ahmad Ehsas | Sprint 3 | Implement-and-rewrite-tests

Sprint-1/readme.md → Sprint-1/Sprint-1/readme.md

@@ -12,7 +12,7 @@ This README will guide you through the different sections for this week.
 
 ## 1 Exercises
 
-In this section, you'll have a short program and task. Some of the syntax may be unfamiliar - in this case, you'll need to look things up in documentation. 
+In this section, you'll have a short program and task. Some of the syntax may be unfamiliar - in this case, you'll need to look things up in documentation.
 
 https://developer.mozilla.org/en-US/docs/Web/JavaScript
 
@@ -28,7 +28,7 @@ You must use documentation to make sense of anything unfamiliar - learning how t
 
 You can also use `console.log` to check the value of different variables in the code.
 
-https://developer.mozilla.org/en-US/docs/Web/JavaScript 
+https://developer.mozilla.org/en-US/docs/Web/JavaScript
 
 ## 4 Explore - Stretch 💪
 

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -8,12 +8,20 @@
 // Then, write the next test! :) Go through this process until all the cases are implemented
 
 function getAngleType(angle) {
-  if (angle === 90) {
-    return "Right angle";
-  }
+
+  if (angle === 90) return "Right angle";
+  if (angle < 90) return "Acute angle";
+  if (angle > 90 && angle < 180) return "Obtuse angle";
+  if (angle === 180) return "Straight angle";
+  if (angle > 180 && angle < 360) return "Reflex angle";
+
+  // read to the end, complete line 36, then pass your test here
+
    // Run the tests, work out what Case 2 is testing, and implement the required code here.
    // Then keep going for the other cases, one at a time.
+
 }
+console.log(getAngleType(120));
 
 // The line below allows us to load the getAngleType function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
@@ -50,14 +58,19 @@ assertEquals(acute, "Acute angle");
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
+assertEquals(obtuse, "Obtuse angle");
 // ====> write your test here, and then add a line to pass the test in the function above
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,9 +8,14 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  }
+  if (Math.abs(numerator) < Math.abs(denominator)) return true; // This version of code works correctly for proper and negative fractions.
+  if (Math.abs(numerator) >= Math.abs(denominator)) return false;
+  if (Math.abs(numerator) === Math.abs(denominator)) return false;
+
+  // if (numerator < denominator) {
+  //   return true;
+  // }
+
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -46,14 +51,21 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction, true); // assertion for negative fraction.
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
+assertEquals(equalFraction, false); // assertion for equal numerator and denominator.
 // ====> complete with your assertion
 
 // Stretch:
 // What other scenarios could you test for?
+console.log(isProperFraction(5, 2));
+console.log(isProperFraction(-4, 7));
+console.log(isProperFraction(-3, 3));
+console.log(isProperFraction(-2, -3)); // This is a proper fraction because the absolute value of numerator 2 and denominator is 3.
+// the value of  numerator is less than denominator.
+console.log(isProperFraction(-4, -7));

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,15 +8,80 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-  if (rank === "A") {
-    return 11;
+  if (typeof card !== "string") {
+    throw new Error("Card must be a string")
   }
-}
+
+  if (card.length < 2) {
+    throw new Error("Invalid card rank")
+  }
+
+  const rank = card.slice(0, -1);
+  const suit = card.slice(-1);
+
+  if (!["♠", "♥", "♦", "♣"].includes(suit)) {
+    throw new Error("Invalid card rank");
+  }
+
+  if (rank === "A") return 11; // Ace 
+
+
+
+  //const rank = card.slice(0, -1); // get the rank (before the suit symbol)
+
+
+ // const num = Number(rank); // converting to a number.
+
+  // if (!isNaN(rank)) {
+  //   return num; // Number card
+  // }
+
+  if (rank === "J" || rank === "Q" || rank === "K") {
+    return 10; // Face cards
+  }
+
+  if (!/^[0-9]+$/.test(rank)) {
+    throw new Error("Invalid card rank");
+  }
+  // Reject weird or malformed ranks (like 3AAAA)
+
+   const num = Number(rank);
+   // Convert numeric string
+
+   if (num >= 2 && num <= 10) {
+    return num;
+  }
+  // Accept valid 2–10 range only
+
+
+
+
+  // Anything else is invalid
+   throw new Error("Invalid card rank")
+
+} 
+
+
+console.log(Number("0x002"));
+console.log(Number("2.1"));
+console.log(Number("9e1"));
+console.log(Number("0002"));
+
+
+
+// if the rank is not a number or a face card, throw an error(invalid card rank).
+
+  // if (rank === "x") {
+  //   return 11;
+  // }
+
+
 
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getCardValue;
 
+
 // You need to write assertions for your function to check it works in different cases
 // we're going to use this helper function to make our assertions easier to read
 // if the actual output matches the target output, the test will pass
@@ -31,21 +96,31 @@ function assertEquals(actualOutput, targetOutput) {
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
+const aceOfSpades = getCardValue("A♠");
+assertEquals(aceOfSpades, 11);
 
 // Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
-// ====> write your test here, and then add a line to pass the test in the function above
+const fiveOfHearts = getCardValue("5♥");
+assertEquals(fiveOfHearts, 5);
+
+const tenOfDiamonds = getCardValue("10♦");
+assertEquals(tenOfDiamonds, 10);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+const jackOfClubs = getCardValue("J♣");
+assertEquals(jackOfClubs, 10);
 
+const queenOfHearts = getCardValue("Q♥");
+assertEquals(queenOfHearts, 10);
+
+const kingOfSpades = getCardValue("K♠");
+assertEquals(kingOfSpades, 10);
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
@@ -55,3 +130,8 @@ const fiveofHearts = getCardValue("5♥");
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+try {
+  getCardValue("Z♠");
+} catch (error) {
+  console.log("Caught error:", error.message); // Should say "Invalid card rank"
+}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -12,15 +12,33 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
+test("should identify acute angle (< 90°)", () => {
+  expect(getAngleType(45)).toEqual("Acute angle");
+});
+// Case 2: identify Acute Angles, When the angle is less than 90 degrees, than the function should return "Acute angle".
 
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
+test("should identify obtuse angle (> 90° and < 180°)", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+});
+// Case 3: identify Obtuse Angles, When the angle is greater than 90 degrees and less than 180 degrees, than the function should return "Obtuse Angle".
+
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
+test("should identify straight angle (180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+// Case 4: identify Straight Angles, When the angle is exactly 180 degrees, than the function should return "Straight angle".
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+test("should identify reflex angle (> 180° and < 360°)", () => {
+  expect(getAngleType(270)).toEqual("Reflex angle");
+});
+// Case 5: identify Reflex Angles, When the angle is greater than 180 degrees and less than 360 degrees, the function should return "Reflex Angle".
+

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,7 +7,21 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for improper fractions", () => {
+  const improperFraction = isProperFraction(5, 2);
+  expect(improperFraction).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return true for negative fractions", () => {
+  const negativeFraction = isProperFraction(-4, 7);
+  expect(negativeFraction).toEqual(true);
+});
+
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  const equalFraction = isProperFraction(3, 3);
+  expect(equalFraction).toEqual(false);
+});
+

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -2,12 +2,58 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getCardValue = require("../implement/3-get-card-value");
 
+
+// Case 4: Handle Ace (A):
 test("should return 11 for Ace of Spades", () => {
   const aceofSpades = getCardValue("A♠");
   expect(aceofSpades).toEqual(11);
 });
 
 // Case 2: Handle Number Cards (2-10):
+test("should return correct values for number cards", () => {
+  expect(getCardValue("5♥")).toEqual(5);
+  expect(getCardValue("10♦")).toEqual(10);
+});
+
+
 // Case 3: Handle Face Cards (J, Q, K):
-// Case 4: Handle Ace (A):
+test("should return for face cards J, Q, K", () => {
+  expect(getCardValue("J♣")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
+  expect(getCardValue("K♠")).toEqual(10);
+});
+
+
+
 // Case 5: Handle Invalid Cards:
+test("throws an error or invalid card", () => {
+  expect(() => getCardValue("Z♠")).toThrow("Invalid card");
+});
+
+test("should throw error for malformed numeric input", () => {
+  expect(() => getCardValue("2.9999♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for repeated characters in rank", () => {
+  expect(() => getCardValue("3AAAA♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for number beyond valid range", () => {
+  expect(() => getCardValue("11♠")).toThrow("Invalid card rank");
+});
+
+test("should throw error for missing suit", () => {
+  expect(() => getCardValue("Q")).toThrow("Invalid card rank");
+});
+
+test("should throw error for non-string input", () => {
+  expect(() => getCardValue(5)).toThrow("Card must be a string");
+});
+
+try {
+getCardValue("Z♠");
+} catch (error) {
+console.log("Caught error:", error.message);
+}
+
+