Skip to content

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | courwork/sprint-2 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | courwork/sprint-2 #741

wants to merge 1 commit into from

Conversation

@wankoak
Copy link

@wankoak wankoak commented Oct 8, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@wankoak
Feat: complete Sprint-2 mandatory and stretch challenges
086b8a5 
Fixed key errors and debugged JavaScript functions

Implemented BMI calculator, case conversion, and unit conversion features

Added time formatting utilities with proper error handling

Completed all mandatory and stretch challenge requirements
@wankoak wankoak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2025
@wankoak wankoak changed the title Birmingham | 25-ITP-Sept | Khor Biel | Sprint 1 | courwork/sprint-2 Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | courwork/sprint-2 Oct 9, 2025
@wankoak wankoak changed the title Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | courwork/sprint-2 Birmingham | 25-ITP-Sept | Khor Biel | Sprint 1 | courwork/sprint-2 Oct 10, 2025
LonMcGregor
LonMcGregor reviewed Oct 15, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@wankoak
Copy link
Author

wankoak commented Oct 15, 2025

@LonMcGregor thank you

@wankoak wankoak changed the title Birmingham | 25-ITP-Sept | Khor Biel | Sprint 1 | courwork/sprint-2 Birmingham | 25-ITP-Sept | Khor Biel | Sprint 2 | courwork/sprint-2 Oct 17, 2025
@wankoak wankoak mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wankoak @LonMcGregor