London | 25-ITP-September | Ammad Ur Rehman | Sprint 3 | 02 Complete Sprint 3 implement and rewrite tests coursework #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anosidium
added
the
Needs Review
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Show resolved
Hide resolved
A-O-Emmanuel
added
Reviewed
Author
|
@cjyuan Could I please get your opinion on my pull request? Thank you. |
cjyuan
reviewed
Oct 28, 2025
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
anosidium
added
Needs Review
cjyuan
reviewed
Oct 29, 2025
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
cjyuan
added
Reviewed
anosidium
added
Needs Review
cjyuan
added
Reviewed
anosidium
removed
the
Reviewed
anosidium
added
the
Needs Review
cjyuan
added
Reviewed
… an error to be thrown
…the rank when it comes to handling number cards
anosidium
added
Needs Review
Contributor
|
Changes look great! |
cjyuan
removed
the
Needs Review
Contributor
|
@A-O-Emmanuel What do you think? |
cjyuan
added
Needs Review
Contributor
|
@A-O-Emmanuel I will mark this PR as complete first. If there is anything you would like @anosidium to follow up, please let him know. Thanks. |
|
okay @cjyuan nothing else, thank you |
Author
|
Thank you very much for reviewing my pull request, @cjyuan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed all the exercises.
Questions
I find the card system confusing. I don't understand the numerical value for each card. The table on Wikipedia didn't help. Where do I find the explanation about the numerical value for each card?