Skip to content

Conversation

@anosidium
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I completed all the exercises.

Questions

I find the card system confusing. I don't understand the numerical value for each card. The table on Wikipedia didn't help. Where do I find the explanation about the numerical value for each card?

@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2025
@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025
@anosidium
Copy link
Author

@cjyuan Could I please get your opinion on my pull request? Thank you.

@anosidium anosidium added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@anosidium anosidium added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@anosidium anosidium removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Oct 29, 2025
@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 29, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025
@anosidium anosidium added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 30, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Oct 30, 2025

Changes look great!

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 30, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Oct 30, 2025

@A-O-Emmanuel What do you think?

@cjyuan cjyuan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 30, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 1, 2025

@A-O-Emmanuel I will mark this PR as complete first. If there is anything you would like @anosidium to follow up, please let him know. Thanks.

@A-O-Emmanuel
Copy link

okay @cjyuan nothing else, thank you

@anosidium
Copy link
Author

Thank you very much for reviewing my pull request, @cjyuan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants