Birmingham | 25-ITP-Sep | Hadi-Vahidi| Sprint 3 |Coursework/sprint-3-practice-tdd #830

HadiVahidi20 · 2025-10-31T17:42:43Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

all tasks are done thank you very much

Questions

…lity

cjyuan · 2025-11-08T00:38:17Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  const twoLastDig = num % 100;
+  if (twoLastDig === 11 || twoLastDig === 12 || twoLastDig === 13) {
+    return num + "th";
+  }
+
+  const lastDig = num % 10;
+  if (lastDig === 1) return num + "st";
+  if (lastDig === 2) return num + "nd";
+  if (lastDig === 3) return num + "rd";
+  return num + "th";


Keeping it or its in the variable names would probably make them more meaningful.

cjyuan · 2025-11-08T00:38:56Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should return '11th' for 11", () => {
+  expect(getOrdinalNumber(11)).toEqual("11th");
+});
+
+test("should return '2nd' for 2", () => {
+  expect(getOrdinalNumber(2)).toEqual("2nd");
+});
+
+
+test("should return '23rd' for 23rd", () => {
+  expect(getOrdinalNumber(23)).toEqual("23rd");
+});
+test("should return '3rd' for 3", () => {
+  expect(getOrdinalNumber(3)).toEqual("3rd");
+});
+test("should return '4th' for 4", () => {
+  expect(getOrdinalNumber(4)).toEqual("4th");
+});
+
+test("should return '12th' for 12", () => {
+  expect(getOrdinalNumber(12)).toEqual("12th");
+});
+test("should return '13th' for 13", () => {
+  expect(getOrdinalNumber(13)).toEqual("13th");
+});
+
+
+test("should return '101st' for 101", () => {
+  expect(getOrdinalNumber(101)).toEqual("101st");
+});


To ensure thorough testing, we need broad scenarios that cover all possible cases.
Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories.
Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

cjyuan · 2025-11-08T00:39:31Z

Sprint-3/2-practice-tdd/repeat.js

+  if(count<0){
+    return "invalid"
+  }


How would the caller distinguish the result of the following two function calls?

repeat("invalid", 1)

repeat("", -1)

cjyuan · 2025-11-08T00:40:01Z

Sprint-3/2-practice-tdd/repeat-str.test.js

+test("should repeat the string count times", () => {
+  const str = "hello";
+  const count = -1;
+  const repeatedStr = repeat(str, count);
+  expect(repeatedStr).toEqual("invalid");
+});


If you modified repeat() to throw an error when count is negative, and you wanted to test if the function can throw an error as expected, you can use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)

…us return values

HadiVahidi20 · 2025-11-09T19:29:58Z

hi Cj
thank you very much for reviewing my PR, I tried to correct and update the code base on your comments.

cjyuan

The changes made to the repeat() function and its tests look good.

cjyuan · 2025-11-09T19:57:38Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  const itsTwoLastDigs = num % 100;
+  if (itsTwoLastDigs === 11 || itsTwoLastDigs === 12 || itsTwoLastDigs === 13) {
    return num + "th";


How should its be included into twoLastDig to make the variable name more meaningful than itsTwoLastDigs?

cjyuan · 2025-11-09T20:05:05Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+describe("getOrdinalNumber", () => {
+  test("append 'st' to numbers ending in 1 expect 11", () => {
+    expect(getOrdinalNumber(1)).toEqual("1st");
+    expect(getOrdinalNumber(101)).toEqual("101st");
+  });
+  test("should return '11th' for 11", () => {
+    expect(getOrdinalNumber(11)).toEqual("11th");
+  });
+
+  test("append 'rd' to numbers ending in 3", () => {
+    expect(getOrdinalNumber(3)).toEqual("3rd");
+    expect(getOrdinalNumber(23)).toEqual("23rd");
+    expect(getOrdinalNumber(33)).toEqual("33rd");
+    expect(getOrdinalNumber(103)).toEqual("103rd");
+  });
+  test("should return '4th' for 4", () => {
+    expect(getOrdinalNumber(4)).toEqual("4th");
+  });
+
+  test("should return '12th' for 12", () => {
+    expect(getOrdinalNumber(12)).toEqual("12th");
+  });
+  test("should return '13th' for 13", () => {
+    expect(getOrdinalNumber(13)).toEqual("13th");
+  });
+
+  test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
+    expect(getOrdinalNumber(2)).toEqual("2nd");
+    expect(getOrdinalNumber(22)).toEqual("22nd");
+    expect(getOrdinalNumber(132)).toEqual("132nd");
+  });


These test categories have been improved but still not fully comprehensive; collectively they haven't yet covered all possible cases.

And you can consider merge some of these tests into one category.

Can you try to further improve them. Feel free to ask AI for some suggestions.

Renamed variables for clarity and added more complete, grouped test cases

HadiVahidi20 · 2025-11-11T11:00:33Z

Thank you for your feedback! I have updated the variable names to make them clearer and also improved the test cases by adding more examples and grouping similar ones together.

HadiVahidi20 · 2025-11-11T11:00:45Z

Thank you for your feedback! I have updated the variable names to make them clearer and also improved the test cases by adding more examples and grouping similar ones together.

cjyuan

Changes look good.

cjyuan · 2025-11-11T11:18:36Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+  test("handles negative numbers", () => {
+    expect(getOrdinalNumber(-1)).toBe("-1st");
+    expect(getOrdinalNumber(-11)).toBe("-11th");
  });


Did you prepare this test because the function is supposed to behave like that, or because your function is behaving like that?

HadiVahidi20 added 9 commits September 29, 2025 17:45

Add age calculation functionality and HTML structure for age input

1189fcd

Refactor age calculator layout and improve form structure

78b6a33

addWnetListener Example added

ea977e5

Refactor age calculator layout and improve form structure

22c0fee

percentage exersice added

c346f52

Enhance percentage exercise layout and add area calculation functiona…

ea0fca9

…lity

Implement countChar function and tests

15f6b6b

Implement countChar function and tests

a135b88

the get-ordinal-number test is done

0036b8d

HadiVahidi20 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 31, 2025

cjyuan reviewed Nov 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

HadiVahidi20 added 3 commits November 8, 2025 15:19

Merge branch 'CodeYourFuture:main' into main

70bf4d4

Merge branch 'main' into coursework/sprint-3-practice-tdd

8d5db28

refactor: throw error for negative count in repeat() to avoid ambiguo…

1413394

…us return values

HadiVahidi20 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 9, 2025

cjyuan reviewed Nov 9, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 9, 2025

Improve variable names and test coverage for getOrdinalNumber

a57813f

Renamed variables for clarity and added more complete, grouped test cases

HadiVahidi20 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 11, 2025

cjyuan reviewed Nov 11, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025

HadiVahidi20 mentioned this pull request Nov 15, 2025

ITP Sep 2025 | Structuring and testing data | Hadi Vahidi HadiVahidi20/My-Coursework-Planner#7

Open

Uh oh!

Birmingham | 25-ITP-Sep | Hadi-Vahidi| Sprint 3 |Coursework/sprint-3-practice-tdd #830

Are you sure you want to change the base?

Birmingham | 25-ITP-Sep | Hadi-Vahidi| Sprint 3 |Coursework/sprint-3-practice-tdd #830

Uh oh!

Conversation

HadiVahidi20 commented Oct 31, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

HadiVahidi20 commented Nov 9, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

HadiVahidi20 commented Nov 11, 2025

Uh oh!

HadiVahidi20 commented Nov 11, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants