Skip to content

Conversation

@Ameneh-Keshavarz
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Ameneh-Keshavarz Ameneh-Keshavarz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 6, 2025
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every script is a great example of how to write jq commands, and each works very well and matches the input perfectly. Keep it up!

# Your output should contain 6 lines, each with just one word on it.
# Your output should not contain any quote characters.

jq -r '.[].name' scores.json No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: be careful with whitespace here

# Your output should contain 6 lines, each with one word and one number on it.
# The first line should be "Ahmed 1" with no quotes.

jq -r '.[] | .name + " " + (.scores[0]|tostring)' scores.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Great work casting types to get this working correctly

@ehwus ehwus added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 16, 2025
@Ameneh-Keshavarz Ameneh-Keshavarz added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants