Skip to content

miguel/post modal responsiveness #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyyort merged 1 commit into from
Oct 7, 2025
Merged

miguel/post modal responsiveness #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/codebility/app/home/feeds/_components/CreatePostForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const CreatePostForm = ({
return (
<form
onSubmit={handleSubmit}
className={`flex flex-col gap-4 ${className}`}
className={`flex max-h-[calc(90vh-8rem)] flex-col gap-4 overflow-y-auto ${className}`}
>
<Input
name="title"
Expand All @@ -86,8 +86,9 @@ const CreatePostForm = ({
/>

{/* Optional image input */}

<ThumbnailUpload onChange={setImage} />
<div className="flex-none">
<ThumbnailUpload onChange={setImage} />
</div>

<MarkdownEditor
initialValue={"# Hello"}
Expand Down
7 changes: 4 additions & 3 deletions apps/codebility/app/home/feeds/_components/EditPostForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const EditPostForm = ({
return (
<form
onSubmit={handleSubmit}
className={`flex flex-col gap-4 ${className}`}
className={`flex max-h-[calc(90vh-8rem)] flex-col gap-4 overflow-y-auto ${className}`}
>
<Input
name="title"
Expand All @@ -98,8 +98,9 @@ const EditPostForm = ({
/>

{/* Optional image input */}

<ThumbnailUpload onChange={setImage} defaultImage={post.image_url} />
<div className="flex-none">
<ThumbnailUpload onChange={setImage} defaultImage={post.image_url} />
</div>

<MarkdownEditor
initialValue={content}
Expand Down
23 changes: 11 additions & 12 deletions apps/codebility/app/home/feeds/_components/MarkdownEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@ export default function MarkdownEditor({
}, [value, onChange]);

useEffect(() => {
// Auto-resize textarea for nicer UX
const ta = textareaRef.current;
if (!ta) return;
ta.style.height = "0px";
ta.style.height = Math.min(ta.scrollHeight, 800) + "px"; // limit max-height
// No auto-resize needed - textarea now uses flex to fill available space
}, [value, tab]);

// notify parent whenever uploadedIds changes
Expand Down Expand Up @@ -76,8 +72,11 @@ export default function MarkdownEditor({
};

return (
<div className="mx-auto w-full max-w-4xl rounded-2xl bg-white p-4 shadow dark:bg-gray-900">
<div className="mb-3 flex items-center justify-between">
<div
className="flex w-full max-w-4xl flex-col rounded-2xl bg-white p-4 shadow dark:bg-gray-900"
style={{ height: "calc(100vh - 36rem)" }}
>
<div className="mb-3 flex flex-shrink-0 items-center justify-between">
<div className="flex gap-1 rounded-md bg-gray-100 p-1 dark:bg-gray-800">
<button
type="button"
Expand Down Expand Up @@ -107,20 +106,20 @@ export default function MarkdownEditor({
</div>
</div>

<div className="overflow-hidden rounded-lg border border-gray-200 dark:border-gray-700">
<div className="flex min-h-0 flex-1 flex-col overflow-hidden rounded-lg border border-gray-200 dark:border-gray-700">
{tab === "write" ? (
<div className="p-4">
<div className="flex flex-1 flex-col overflow-hidden p-4">
<textarea
ref={textareaRef}
value={value}
onChange={(e) => setValue(e.target.value)}
onPaste={handlePaste}
placeholder="# Start typing markdown..."
className="max-h-[600px] min-h-[160px] w-full resize-none bg-transparent text-sm leading-relaxed text-gray-900 outline-none dark:text-gray-100"
className="h-full w-full resize-none bg-transparent text-sm leading-relaxed text-gray-900 outline-none dark:text-gray-100"
/>
</div>
) : (
<div className="prose prose-sm dark:prose-invert max-h-[600px] min-h-[160px] max-w-none overflow-y-auto p-4 text-sm">
<div className="prose prose-sm dark:prose-invert h-full max-w-none overflow-y-auto p-4 text-sm">
{value.trim() ? (
<ReactMarkdown remarkPlugins={[remarkGfm]}>{value}</ReactMarkdown>
) : (
Expand All @@ -133,7 +132,7 @@ export default function MarkdownEditor({
)}
</div>

<div className="mt-3 flex items-center justify-between text-xs text-gray-500 dark:text-gray-400">
<div className="mt-3 flex flex-shrink-0 items-center justify-between text-xs text-gray-500 dark:text-gray-400">
<div>Characters: {value.length}</div>
<div className="flex gap-2">
<button
Expand Down