Edit notable figure general entries #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dusch4593
added
enhancement
KTom101
suggested changes
Jun 23, 2022
Contributor
KTom101
left a comment
KTom101
left a comment
There was a problem hiding this comment.
@Dusch4593 Only saw a couple of things.
| **Aaron Swartz** (1986-2013) was an American programmer, writer, entrepreneur, and internet activist. He was involved in the development of the RSS web feed format, [Markdown](https://www.codecademy.com/resources/docs/markdown) language, [Creative Commons licenses](https://creativecommons.org/), and Python web framework [web.py](https://webpy.org/). | ||
|
|
||
| He was a co-founder of a startup called Infogami, which later became the social news site Reddit. In his later years, he co-founded an activist organization, Demand Progress, and led the charge fighting the Stop Online Piracy Act (SOPA). | ||
|
|
Contributor
There was a problem hiding this comment.
while we're here can we fix line 29 (or 27 in the original)? I think it's supposed to say "mass download" not "massive download".
| Description: 'Ada Lovelace was an English writer and mathematician and is often considered to be the first computer programmer. Lovelace is known for her work on Charles Babbages Analytical Engine, the first programmable general-purpose computer.' | ||
| Subjects: | ||
| - 'Computer Science' | ||
| - 'Code Foundations' |
Contributor
There was a problem hiding this comment.
While we're in here, I would fix the punctuation in the description on line 3. "Charles Babbages" should be "Charles Babbage's".
Contributor
Author
There was a problem hiding this comment.
Gotcha. I think I might have left that out to prevent a check fail but I think I can probably remove his name entirely from the Description 😄
Co-authored-by: KTom101 <kyrathompson@me.com>
Contributor
Author
|
@KTom101 I believe I implemented all your feedback 😄 |
KTom101
approved these changes
Jun 23, 2022
Contributor
KTom101
left a comment
KTom101
left a comment
There was a problem hiding this comment.
@Dusch4593 I see one more change, otherwise, it is good.
Co-authored-by: KTom101 <kyrathompson@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to spruce up the existing general entries about famous individuals in programming/computer science, including:
On this last point, I really think we should add more entries about other famous figures in programming/computer science (and include images, if possible). Some that come to mind are:
Type of Change
Checklist
mainbranch.