Skip to content

Comments

Updated to use newer version of Symfony Demo app (1.3.4)#18

Merged
Naktibalda merged 269 commits intomasterfrom
pgl-master
Nov 23, 2019
Merged

Updated to use newer version of Symfony Demo app (1.3.4)#18
Naktibalda merged 269 commits intomasterfrom
pgl-master

Conversation

@Naktibalda
Copy link
Member

Replaces #15

javiereguiluz and others added 30 commits January 3, 2018 09:48
…reguiluz)

This PR was merged into the master branch.

Discussion
----------

Updated the license year (for the last time)

Following Symfony's practices (see symfony/symfony#25647).

Commits
-------

4337e4e Updated the license year (for the last time)
This PR was merged into the master branch.

Discussion
----------

Use Sf4 path for security.yaml file

Commits
-------

bc36ffa Use Sf4 path for security.yaml file
Alerts currently can't be dismissed in the symfony-demo app.
Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript
…4, Peter)

This PR was merged into the master branch.

Discussion
----------

Including alerts.js and changing loading order

Alerts currently can't be dismissed in the symfony-demo app.
Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript

Commits
-------

5375d40 Adding .fade and .in to use animation when closing
b0ac79c Yarn'd for prod
c39d745 Yarn'd after including alert.js
10a7ba8 Fixing a typo
364c6b0 Including alerts.js and changing loading order
This PR was merged into the master branch.

Discussion
----------

Correcting sf4 config path

Commits
-------

6db8ba9 Update the SwiftMailer dev config to match recipe
a86bda3 Removing requirement to register twig extension in services.yaml
9c8ed6d Fixing swiftmailer config path and added missing config for dev env
e4bdc3d Fixing path in Entity/Post
…directory (yceruto)

This PR was merged into the master branch.

Discussion
----------

Remove unnecessary configuration for translations/ directory

Now it's in the core.

Commits
-------

e00162c Remove unnecessary configuration for translations/ directory
menu.search and post.search_for were missing
This PR was merged into the master branch.

Discussion
----------

Minor: added missing translations

menu.search and post.search_for were missing

Commits
-------

35377a2 Minor: added missing translations
This PR was merged into the master branch.

Discussion
----------

Fixed small typos

Commits
-------

fcbb09c Fixed small typos
This PR was merged into the master branch.

Discussion
----------

Updated dependencies to Symfony 4.0.3

Changelog:

  - Removing symfony/thanks (v1.0.0)
  - Removing symfony/profiler-pack (v1.0.3)
  - Removing symfony/orm-pack (v1.0.5)
  - Updating symfony/flex (v1.0.49 => v1.0.65)
  - Updating symfony/console (v4.0.2 => v4.0.3)
  - Updating symfony/debug (v4.0.2 => v4.0.3)
  - Updating doctrine/inflector (v1.2.0 => v1.3.0)
  - Updating doctrine/orm (v2.5.14 => v2.6.0)
  - Updating symfony/http-foundation (v4.0.2 => v4.0.3)
  - Updating symfony/event-dispatcher (v4.0.2 => v4.0.3)
  - Updating symfony/http-kernel (v4.0.2 => v4.0.3)
  - Updating symfony/dependency-injection (v4.0.2 => v4.0.3)
  - Updating symfony/routing (v4.0.2 => v4.0.3)
  - Updating symfony/finder (v4.0.2 => v4.0.3)
  - Updating symfony/filesystem (v4.0.2 => v4.0.3)
  - Updating symfony/config (v4.0.2 => v4.0.3)
  - Updating symfony/cache (v4.0.2 => v4.0.3)
  - Updating symfony/framework-bundle (v4.0.2 => v4.0.3)
  - Updating sensio/framework-extra-bundle (v5.1.3 => v5.1.4)
  - Updating sensiolabs/security-checker (v4.1.6 => v4.1.7)
  - Updating symfony/asset (v4.0.2 => v4.0.3)
  - Updating symfony/expression-language (v4.0.2 => v4.0.3)
  - Updating symfony/inflector (v4.0.2 => v4.0.3)
  - Updating symfony/property-access (v4.0.2 => v4.0.3)
  - Updating symfony/options-resolver (v4.0.2 => v4.0.3)
  - Updating symfony/intl (v4.0.2 => v4.0.3)
  - Updating symfony/form (v4.0.2 => v4.0.3)
  - Updating symfony/security (v4.0.2 => v4.0.3)
  - Updating symfony/security-bundle (v4.0.2 => v4.0.3)
  - Updating symfony/translation (v4.0.2 => v4.0.3)
  - Updating symfony/validator (v4.0.2 => v4.0.3)
  - Updating symfony/yaml (v4.0.2 => v4.0.3)
  - Updating symfony/twig-bridge (v4.0.2 => v4.0.3)
  - Updating symfony/twig-bundle (v4.0.2 => v4.0.3)
  - Updating white-october/pagerfanta-bundle (v1.1.1 => v1.1.2)
  - Updating symfony/doctrine-bridge (v4.0.2 => v4.0.3)
  - Updating dama/doctrine-test-bundle (v4.0.1 => v4.0.2)
  - Updating symfony/stopwatch (v4.0.2 => v4.0.3)
  - Updating symfony/process (v4.0.2 => v4.0.3)
  - Updating friendsofphp/php-cs-fixer (v2.9.0 => v2.10.0)
  - Updating symfony/dom-crawler (v4.0.2 => v4.0.3)
  - Updating symfony/browser-kit (v4.0.2 => v4.0.3)
  - Updating symfony/css-selector (v4.0.2 => v4.0.3)
  - Updating symfony/var-dumper (v4.0.2 => v4.0.3)
  - Updating symfony/debug-bundle (v4.0.2 => v4.0.3)
  - Updating symfony/dotenv (v4.0.2 => v4.0.3)
  - Updating symfony/phpunit-bridge (v4.0.2 => v4.0.3)
  - Updating symfony/web-profiler-bundle (v4.0.2 => v4.0.3)
  - Updating symfony/web-server-bundle (v4.0.2 => v4.0.3)
  - Updating symfony/monolog-bridge (v4.0.2 => v4.0.3)

Commits
-------

06dcb15 Updated dependencies to Symfony 4.0.3
…eruto)

This PR was merged into the master branch.

Discussion
----------

Add service Tag repository and revamping code

This completes throughout the demo that amazing feature that is "Service Entity Repository".

Commits
-------

5209859 Add service Tag repository and revamping code
…ns and PHPStan (javiereguiluz)

This PR was squashed before being merged into the master branch (closes symfony#757).

Discussion
----------

Minor code fixes found with PhpStorm, Php Inspections and PHPStan

Commits
-------

953009f Minor code fixes found with PhpStorm, Php Inspections and PHPStan
…t Symfony file (javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Keep the services.yaml file in sync with the default Symfony file

In this demo app we always keep config files in sync with those provided by the Symfony recipes. This makes the config easier to understand for newcomers (there will be no surprises because when they install Symfony, they'll get the same config they saw on this app).

In addition, I think it's a good idea to keep the `App\Controller\` config. It's true that technically we don't need it because our controllers extend from the base controller. But having this config explicitly, makes it easier to understand what's going on with the services created from controllers.

Commits
-------

3bb3928 Keep the services.yaml file in sync with the default Symfony file
javiereguiluz and others added 27 commits February 4, 2019 13:23
This PR was merged into the master branch.

Discussion
----------

Added missing return types

Commits
-------

386f504 Added missing return types
This PR was merged into the master branch.

Discussion
----------

Updated dependencies to Symfony 4.2.3

Commits
-------

729732a Updated to Symfony 4.2.3
…opin)

This PR was merged into the master branch.

Discussion
----------

Migrate from HTMLPurifier to html-sanitizer

I would like to propose the usage of html-sanitizer in remplacement of HTMLPurifier.

html-sanitizer is well integrated in modern Symfony applications (autowiring / autoconfiguration), it is better suited than HTMLPurifier to sanitize user inputs such as Markdown, it is faster and it creates HTML that's simpler and easier to understand. It is also IMO easier to extends and configure.

Commits
-------

13c5b03 Migrate from HTMLPurifier to html-sanitizer
…explicit string (inmarelibero)

This PR was squashed before being merged into the master branch (closes symfony#948).

Discussion
----------

symfony#946 use Voter constants instead of plain explicit string

address issue symfony#946

Commits
-------

9ace78f symfony#946 use Voter constants instead of plain explicit string
This PR was squashed before being merged into the master branch (closes symfony#947).

Discussion
----------

Adding Lithuania translation

Interesting that nobody have added Lithuania translation of demo application. In Lithuania Symfony is very popular and maybe for new users will be useful to see Lithuania translation.

Commits
-------

9020a0b Adding Lithuania translation
…e in the login page (javiereguiluz)

This PR was squashed before being merged into the master branch (closes symfony#949).

Discussion
----------

Redirect to the right page after changing the locale in the login page

This fixes the problem reported in symfony/symfony-docs#10864

I don't think this is a Symfony bug or a Demo app bug ... I think it's an edge case for the reasons explained in the code ... and that's why I propose this solution.

Commits
-------

e493643 Redirect to the right page after changing the locale in the login page
This PR was merged into the master branch.

Discussion
----------

Updated dependencies to Symfony 4.2.4

Commits
-------

8350ff2 Updated dependencies to Symfony 4.2.4
This PR was merged into the master branch.

Discussion
----------

new link [skip-ci]

Commits
-------

5a1dec5 new link
This was redirecting all logins to the URL of the admin_index route - so normal
users see a 403 page.
This was redirecting all logins to the URL of the admin_index route - so normal
users see a 403 page.

Bug submitted here: symfony#962
@Naktibalda Naktibalda merged commit 1679461 into master Nov 23, 2019
@Naktibalda Naktibalda deleted the pgl-master branch November 23, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.