Skip to content

Enable full HTML5 theme support#4168

Merged
preda-bogdan merged 3 commits into
developmentfrom
feat/html5-support
Jan 26, 2024
Merged

Enable full HTML5 theme support#4168
preda-bogdan merged 3 commits into
developmentfrom
feat/html5-support

Conversation

@Soare-Robert-Daniel

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Summary

Not having HTML5 support for scripts might impact some users who use specific plugins. More context about the problem here

Will affect visual aspect of the product

NO

Test instructions

  • Make sure that the build is OK.

Check before Pull Request is ready:

Closes #4167

@Soare-Robert-Daniel

Copy link
Copy Markdown
Contributor Author

@preda-bogdan, I see that for block themes, WP allows all options for HTML5 https://sourcegraph.com/github.com/WordPress/WordPress@46406afcc4cc938f44115c49ae775bad52039710/-/blob/wp-includes/theme.php?L4330:2

Should we do the same? Is there anything that you think we might have a conflict?

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 7, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 7, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 7, 2023 that may be closed by this pull request
@preda-bogdan

preda-bogdan commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

@Soare-Robert-Daniel I don't see any reason for conflicts, I think it is not present because it was not available and no explicit request was made. We can test and confirm it works as expected.

Also you would need to check that the layout and styles work as before, if not maybe limit the scope of the html5 feature as detailed here: https://developer.wordpress.org/reference/functions/add_theme_support/#html5 to only be available for script since the issue mentioned that as a requirement and not necessary full support.

@Soare-Robert-Daniel

Copy link
Copy Markdown
Contributor Author

I looked at what changes it enables, and I think we will not be affected. Most of them are related to core shortcodes, which enable new HTML syntax like caption.

Reference: https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/WordPress/WordPress$+current_theme_supports(+'html5'&patternType=standard&sm=1&groupBy=path

@Soare-Robert-Daniel
Soare-Robert-Daniel marked this pull request as ready for review December 8, 2023 11:22
@pirate-bot

pirate-bot commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

Plugin build for 67923bc is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Enable HTML5 theme support for scripts Enable full HTML5 theme support Dec 8, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 8, 2023
@irinelenache

Copy link
Copy Markdown
Contributor

@Soare-Robert-Daniel Tested the WP Popular posts compatibility and it works fine now, thank you 🚀

@preda-bogdan
preda-bogdan merged commit 71aa913 into development Jan 26, 2024
@preda-bogdan
preda-bogdan deleted the feat/html5-support branch January 26, 2024 11:05
@pirate-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for HTML5 script tags

4 participants