Enable full HTML5 theme support#4168
Conversation
|
@preda-bogdan, I see that for block themes, WP allows all options for HTML5 https://sourcegraph.com/github.com/WordPress/WordPress@46406afcc4cc938f44115c49ae775bad52039710/-/blob/wp-includes/theme.php?L4330:2 Should we do the same? Is there anything that you think we might have a conflict? |
|
@Soare-Robert-Daniel I don't see any reason for conflicts, I think it is not present because it was not available and no explicit request was made. We can test and confirm it works as expected. Also you would need to check that the layout and styles work as before, if not maybe limit the scope of the html5 feature as detailed here: https://developer.wordpress.org/reference/functions/add_theme_support/#html5 to only be available for |
|
I looked at what changes it enables, and I think we will not be affected. Most of them are related to core shortcodes, which enable new HTML syntax like |
|
@Soare-Robert-Daniel Tested the WP Popular posts compatibility and it works fine now, thank you 🚀 |
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Not having HTML5 support for scripts might impact some users who use specific plugins. More context about the problem here
Will affect visual aspect of the product
NO
Test instructions
Check before Pull Request is ready:
Closes #4167