Validated WC cart object to prevent fatal error - #4558
Merged
Conversation
pirate-bot
added
the
pr-checklist-complete
girishpanchal30
force-pushed
the
bugfix/4555
branch
from
August 3, 2026 13:24
93c93d4 to
22bea0e
Compare
Collaborator
There was a problem hiding this comment.
Pull request overview
Prevents WooCommerce cart rendering from fatally dereferencing a missing cart object.
Changes:
- Adds cart-object guards to legacy and Header Footer Grid renderers.
- Adds PHPUnit coverage and minimal WooCommerce stubs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
inc/views/header.php |
Guards legacy navigation cart rendering. |
header-footer-grid/Core/Components/CartIcon.php |
Guards builder cart rendering. |
tests/test-neve-cart-guards.php |
Tests unavailable and initialized cart states. |
tests/stubs/woocommerce-cart.php |
Provides isolated WooCommerce test doubles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
selul
requested changes
Aug 4, 2026
selul
left a comment
selul
left a comment
Contributor
There was a problem hiding this comment.
Guard is right, but an identical sink is left open elsewhere.
selul
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a validation for the WooCommerce cart object before rendering the cart icon in the Header Footer Grid, preventing fatal errors when the cart object is unavailable.
Check before Pull Request is ready:
Closes #4555