fix: reconcile MCP delivery silence - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Forge correctly models MCP liveness per negotiated client connection, but the stale-session sweep treated every quiet connection as possible active work. Completed runs, terminal issues, and otherwise-ready issues could therefore retain an “MCP status unconfirmed” ask, and completion evaluation counted that recovery ask as an independent operator decision.
Impact
Desktop reconnects remain session-specific and do not falsely confirm older clients. Operators now see an active-run warning only when a run is actually active; completed delivery asks for an explicit disposition, terminal issues clear obsolete recovery noise, and safe completion evidence supersedes the redundant coordination warning.
Validation
pnpm lint— passed with existing repository warningspnpm typecheck— passedImplements AXI-151