fix: use login shell for AI tool detection to respect user PATH#43
Merged
Conversation
On macOS (and Linux), Electron GUI apps inherit a minimal system PATH and never source the user's shell profile (~/.zshrc, ~/.bashrc). This caused `which claude` to fail even when Claude Code was installed in ~/.local/bin and working fine in SubFrame's own terminal. Two concrete fixes: - Absolute paths (e.g. /Users/foo/.local/bin/claude): check file existence and executability via fs.access() instead of running `which`, so a user-provided full path always resolves correctly. - Simple command names (e.g. `claude`): spawn the user's configured login shell with the -l flag, mirroring the same PATH that terminal sessions see. Closes #35 Co-authored-by: Bailey Dixon <Codename-11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
On macOS/Linux, Electron GUI apps inherit a minimal system PATH and never source the user's shell profile. This caused the "Claude Code (not installed)" false positive when the binary lived in a profile-defined path like ~/.local/bin.
Two concrete fixes:
Generated with Claude Code