Skip to content

read description - #1016

Merged
Raltyro merged 3 commits into
CodenameCrew:mainfrom
sillyburg:fix-nums
Jun 28, 2026
Merged

read description#1016
Raltyro merged 3 commits into
CodenameCrew:mainfrom
sillyburg:fix-nums

Conversation

@sillyburg

@sillyburg sillyburg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

this changes some things about PR #1015

  • rename tween to playTween
  • use the recycle function for positioning in displayRatingNumbers
  • add "tween" variable (which is an FlxTween instance, not to be confused with playTween)
  • fix returns
2026-06-28.00-31-34.mp4

@sillyburg
read description
6a63b2f 
- rename tween to playTween
- use the recycle function for positioning in displayRatingNumbers
- add "tween" variable (which is an FlxTween instance, not to be confused with playTween)
- fix returns
@sillyburg

sillyburg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

raltyro merge my amazing pr it'll make me happy

@NexIsDumb

NexIsDumb commented Jun 28, 2026

Copy link
Copy Markdown
Member

i dont feel like changing the name of an event variable that people alreayd use in their mods is good, rather keep that tween and find a better name for the tween instance, like maybe tweenInstance or something

@sillyburg

sillyburg commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

i dont feel like changing the name of an event variable that people alreayd use in their mods is good, rather keep that tween and find a better name for the tween instance, like maybe tweenInstance or something

the pr i mentioned got merged like 30 minutes ago so i don't think anyone would be using it

edit: nevermind time passes fast LOL it was one hour ago

@sillyburg

sillyburg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

however i can rename it to tweenInstance if that's what you'd like

@NexIsDumb

NexIsDumb commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

i dont feel like changing the name of an event variable that people alreayd use in their mods is good, rather keep that tween and find a better name for the tween instance, like maybe tweenInstance or something

the pr i mentioned got merged like 30 minutes ago so i don't think anyone would be using it

edit: nevermind time passes fast LOL it was one hour ago

ohhh my bad sorry, didnt see that, then its good dont worry about it, you can revert that last commit if youd like

@sillyburg

sillyburg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

done!

@Raltyro

Raltyro commented Jun 28, 2026

Copy link
Copy Markdown
Member

ok

@Raltyro
Raltyro merged commit 45a2f28 into CodenameCrew:main Jun 28, 2026
@sillyburg

sillyburg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

the Second i turn off my pc ok but TYTYTYTYTYTYTYTY THANK YOU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sillyburg @NexIsDumb @Raltyro