Score model wrong without sending it through serializer

[Danielku15]

Observed Results

When the score model is directly sent into the ScoreRenderer after loading it, it seems that various details are wrong in the overall model. Especially regarding the timing.

This requires currently the unit tests to send it once through the JsonSerializer.

Expected Results

The Score datamodel should be 100% after loading and calling finish.

Steps to Reproduce

1. Remove the serializer part on any of the visual unit test platforms
2. Notice how the rendering fails due to various details being wrong in the model

Further details

As already so often in the past already, the grace timing seems to be one bad player in this bug. The GraceGroup.addBeat uses the absoluteDisplayStart for the unique IDs. But when the first beat is added in Voice.finish on line 187, the timings are not yet defined.

A fix could be to just update the IDs of the grace groups after the display and playback times are defined.

Your environment

Version

• 1.0
• 1.1
• 1.2
• 1.3-alpha.109

Flavor

• JavaScript
• .net