Skip to content

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jan 5, 2026

Issues

Fixes #2467

Proposed changes

based on the changes of @L-Sun I further refactored the current code around percussion articulations.

The complexity of this PR shows how nasty the mapping close to GuitarPro is. its index-based articulation lookup (vs. an id lookup), and the historical problems scream for a rework. I'd with GP would use proper unique IDs for the articulations instead of an index and "input midi number" approach.

Generally this PR tries to prepare already some model areas for having a "articulation by id" approach.

  • When exporting GP files we try to lookup any known articulation and additionally write the RSE information we have.
  • For MusicXML we try to match articulations by the output midi number to allow file conversion flows to work.
  • The general construction of the InstrumentSet is now moved to a dedicated component with the idea that the RSE information could be loaded from a template file in future.

On the way I discovered a bug that the NotationPatch was incorrectly applied as we have to use the Element name for identification.

This change allows using RSE until some extend. Some aspects of the effect chain are not in-place which can lead to strange UI discrepancies (e.g. RSE/SoundbankPatch).

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 5, 2026
@Danielku15 Danielku15 force-pushed the feature/percussion-rse-2 branch from a8a39ab to b5d7155 Compare January 5, 2026 23:27
@Danielku15 Danielku15 changed the title feat: feat: new guitar pro instrument set writing Jan 5, 2026
@Danielku15 Danielku15 marked this pull request as draft January 6, 2026 00:23
@Danielku15 Danielku15 marked this pull request as ready for review January 6, 2026 03:09
@Danielku15 Danielku15 merged commit d04d3be into develop Jan 6, 2026
5 checks passed
@Danielku15 Danielku15 deleted the feature/percussion-rse-2 branch January 6, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exported GP files have no sound when switching drum tracks to RSE in Guitar Pro 8

2 participants