fix: handle harmonic values in gp3-5 at best knowledge#2707
Merged
Conversation
Danielku15
force-pushed
the
feature/gp-harmonic-values
branch
from
44223fb to
75b9bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2689
Proposed changes
Adds reading and handling of GP3-5 harmonic values at best knowledge. The correct behavior is very guitar pro specific and it is not documented how delta-frets / harmonic pitch values should be applied exactly.
The GuitarPro UI allows various configurations which are likely not physically possible. GP8 import of various test files also showed that they fallback to some defaults based on inputs.
The new alphaTab knowledge is an assumption at best knowledge on what is likely meant. If users provide invalid behaviors we would need to selectively check the behavior of the given configuration across versions.
Checklist
Further details