Skip to content

Fix PyPDF2 imports in watermark service - #164

Merged
CoderWanFeng merged 1 commit into
CoderWanFeng:developfrom
echo-wee:fix-pypdf2-modern-imports
Aug 4, 2026
Merged

Fix PyPDF2 imports in watermark service#164
CoderWanFeng merged 1 commit into
CoderWanFeng:developfrom
echo-wee:fix-pypdf2-modern-imports

Conversation

@echo-wee

Copy link
Copy Markdown
Contributor

Summary

  • Remove unused legacy PyPDF2 class imports from the PDF watermark service
  • Keep the module importable with modern PyPDF2 versions that expose PdfReader/PdfWriter only
  • Add an import regression test with a modern PyPDF2-compatible stub

Test

  • python -m unittest tests.test_code.test_pdf_add_watermark_imports

@CoderWanFeng
CoderWanFeng merged commit 3f9e733 into CoderWanFeng:develop Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants