Skip to content

Conversation

@ScriptyChris
Copy link
Member

@ScriptyChris ScriptyChris commented Jul 9, 2016

Added features:

  1. Preview of CKEditor content including code blocks, which was mentioned here: http://forum.pasja-informatyki.pl/132776/podejrzyj-pytanie
  2. Collaping/expanding blocks of code - integrated from here: https://github.com/CodersCommunity/forum.pasja-informatyki.local/tree/collapsing-blocks-of-code-lighterVer

Ad.1:
When user is asking the new question (creating new topic) or adding response or comment - it is now possible to look at the preview (poping up as a Modal sort of box), to see how whole post will be looking like, when added (submited). So any formatting bugs should be seen and possible to correct inside editor before adding post.

Ad.2:
Long lines block of code are making whole topic page longer and so harder (less comfortable) to read by users. Now they are able to collapse. Each block of code is checked if it has more than X lines of code (it can be adjusted by numberOfLines variable - default value is 30). Then user can expand collapsed block of code (appropriate info about current state of block is visible at the top of it). Also every block of code has been given info about code language used in it placed in top right corner.

Source Branch: https://github.com/CodersCommunity/forum.pasja-informatyki.local/tree/feature/collapsing-blocks-of-code-and-post-preview

@awaluk
Copy link
Member

awaluk commented Jul 9, 2016

Dwie rzeczy jakie dostrzegłem:

  1. Może warto by było jakby modal który wyskakuje z podglądem zamykał się po kliknięciu poza nim? Właściwie to nic koniecznego, jest X do zamykania, ale zawsze to jakieś udogodnienie.
  2. Gdy wkleimy link do edytora nie staje się on automatycznie hiperłączem na podglądzie - nie można go otworzyć przez kliknięcie. I tak zostanie zamieniony na hiperłącze, ale już przez samo Q2A. Jeśli wstawimy link normalnie z opcji CKEditora to nie ma problemu, wyświetla się na podglądzie jako klikalne hiperłącze. To też nic wielkiego, drobna różnica między tym co będzie na pytaniu a tym co jest na podglądzie, ewentualnie utrudnienie gdyby ktoś chciał z podglądu sprawdzić co jest pod danym łączem.
    Tyle, więcej rzeczy na razie nie znalazłem, ogólnie podoba mi się.

@ScriptyChris
Copy link
Member Author

@awaluk, dodałem to, co opisałeś w pkt.1: bc2d91e
Co do pkt. 2 - jest to pewnie wykonalne (jakiś regex), ale moim zdaniem wiele osób na to uwagi nie zwróci. Zawsze będzie można to dodać, jeśli jednak zajdzie taka potrzeba ;)

@awaluk
Copy link
Member

awaluk commented Jul 9, 2016

@ChrissP92 jak mówiłem obydwie rzeczy mi osobiście wydają się tylko dodatkami, nie są niezbędne także spoko :)

@awaluk awaluk merged commit 3176ae8 into master Jul 9, 2016
@awaluk awaluk deleted the feature/collapsing-blocks-of-code-and-post-preview branch July 9, 2016 21:49
@efiku efiku added the Assigned label Jul 11, 2016
@efiku
Copy link
Member

efiku commented Jul 11, 2016

Fixed #19

efiku added a commit that referenced this pull request Aug 7, 2016
commit d5de0d4
Merge: 1701619 8e192e1
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Wed Aug 3 18:38:34 2016 +0200

    Merge pull request #39 from CodersCommunity/hotfix/menu-current-page

    Poprawione zaznaczanie aktualnej podstrony w menu

commit 8e192e1
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Aug 2 20:50:25 2016 +0200

    Updated margin in styles

commit c8a5a67
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Thu Jul 28 13:00:42 2016 +0200

    Improved selection current page in menu

commit 1701619
Merge: f3ed3b6 bbee14d
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 26 23:41:16 2016 +0200

    Merge pull request #37 from CodersCommunity/update-database-dump

    Aktualizacja zrzutu bazy danych

commit bbee14d
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 26 21:18:44 2016 +0200

    Updated database dump

commit f3ed3b6
Merge: d7cf53c 8e4d8d6
Author: Krzysztof Pazdur <pazdurk@gmail.com>
Date:   Tue Jul 26 11:47:10 2016 +0200

    Merge branch 'efiku-patch-1'

commit 8e4d8d6
Author: Krzysztof Pazdur <pazdurk@gmail.com>
Date:   Mon Jul 11 10:49:55 2016 +0200

    Update CONTRIBUTING.md

    Dodałem wyjaśnienie odnośnie etykiet.

    Fiexed Typos

commit d7cf53c
Merge: 70325a8 fdad20c
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 19 19:26:01 2016 +0200

    Merge pull request #30 from CodersCommunity/ChrissP92-patch-1

    Update README.MD

commit 70325a8
Merge: 50e1046 624624f
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 19 02:09:08 2016 +0200

    Merge pull request #33 from CodersCommunity/favicon-and-images

    Aktualizacja favicony i przeniesienie kilku obrazków

commit 624624f
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 19 02:02:11 2016 +0200

    Moved favicon and other images

commit 3176346
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Tue Jul 19 01:54:46 2016 +0200

    Update favicon and other images

commit 50e1046
Merge: 6a2d29f 2cc8e0e
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sun Jul 17 21:07:41 2016 +0200

    Merge branch 'feature/inform-to-mark-best-answer-when-closing-topic'

commit 2cc8e0e
Merge: e0a4ee8 6a2d29f
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sun Jul 17 21:07:11 2016 +0200

    Merge - resolve conflicts

commit 6a2d29f
Merge: 2300e4b 3779f19
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sun Jul 17 20:47:35 2016 +0200

    Merge pull request #26 from CodersCommunity/fix/UI-accessibility

    Add keyboard support | fix UI

commit fdad20c
Author: ChrissP92 <krzysztof.pawelec1@gmail.com>
Date:   Sun Jul 17 20:04:08 2016 +0200

    Update README.MD

    Additional way for forum server installation - using XAMPP

commit e0a4ee8
Author: Krzysztof <krzysztof.pawelec1@gmail.com>
Date:   Sun Jul 10 21:30:15 2016 +0200

    Ready for testing and review

commit 3779f19
Author: Adrian Wieprzkowicz <adrian.wieprzkowicz@gmail.com>
Date:   Sun Jul 10 17:03:13 2016 +0200

    Update qa-styles.css

commit bf4e37e
Author: Argeento <adrian.wieprzkowicz@gmail.com>
Date:   Sun Jul 10 13:20:24 2016 +0200

    Add keyboard support | fix UI

commit 2300e4b
Merge: 3176ae8 e12f240
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sun Jul 10 00:03:44 2016 +0200

    Merge branch 'feature/spoj-detection'

commit e12f240
Merge: cf7cfaa 3176ae8
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sun Jul 10 00:03:14 2016 +0200

    Merge

commit 3176ae8
Merge: c93ef56 bc2d91e
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Sat Jul 9 23:49:11 2016 +0200

    Merge pull request #24 from CodersCommunity/feature/collapsing-blocks-of-code-and-post-preview

    Collapsing blocks of code and post preview (integrated features)

commit cf7cfaa
Author: ChrissP92 <krzysztof.pawelec1@gmail.com>
Date:   Sat Jul 9 23:43:29 2016 +0200

    Update ask.php

    Fix - removed unnecessary HTML code

commit 99aef94
Author: Krzysztof <krzysztof.pawelec1@gmail.com>
Date:   Sat Jul 9 19:27:03 2016 +0200

    Recoded and cleaned - ready to merge

commit c0bb2f4
Author: Krzysztof <krzysztof.pawelec1@gmail.com>
Date:   Sat Jul 9 18:28:47 2016 +0200

    Recoding - with CKEDITOR events. Integrated fields detection. Before adding animation

commit f0f5be8
Author: Krzysztof <krzysztof.pawelec1@gmail.com>
Date:   Sat Jul 9 17:59:04 2016 +0200

    Recoding - with CKEDITOR events. Integrating detection of both inputs

commit c93ef56
Merge: ee24661 1bc6c10
Author: Marek Woś <marwo12@gmail.com>
Date:   Wed Jul 6 18:53:24 2016 +0200

    Merge pull request #23 from CodersCommunity/feature/contributing-file

    Dodanie pliku CONTRIBUTING.MD #4

commit 1bc6c10
Author: Marek Woś <marwo12@gmail.com>
Date:   Wed Jul 6 18:51:29 2016 +0200

    Dodanie pliku CONTRIBUTING.MD #4

commit ee24661
Merge: a6400ee aab64bb
Author: Marek Woś <marwo12@gmail.com>
Date:   Wed Jul 6 14:15:52 2016 +0200

    Merge pull request #21 from CodersCommunity/hotfix/sidebar-mess

    [Fix] Błędne wyświetlanie boksu

commit aab64bb
Author: Marek Woś <marwo12@gmail.com>
Date:   Wed Jul 6 14:14:01 2016 +0200

    [Fix] Błędne wyświetlanie boksu

    Prawdopodobny fix z błędnie wyświetlanym panelem.

commit a6400ee
Merge: 926a343 0d4342f
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Wed Jul 6 12:32:46 2016 +0200

    Merge pull request #17 from CodersCommunity/feature/disable-email-notification

    Opcja pozwalająca wyłączyć e-mailowe powiadomienia o wiadomościach prywatnych

commit 0d4342f
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Mon Jul 4 21:42:21 2016 +0200

    Update database dump - added 1 column in qa_users

commit 778b574
Author: Arkadiusz Waluk <arkadiusz@waluk.pl>
Date:   Mon Jul 4 20:57:10 2016 +0200

    Added option to disable the e-mails notification about private messages

commit 088891d
Author: Krzysztof <krzysztof.pawelec1@gmail.com>
Date:   Mon Jul 4 19:05:31 2016 +0200

    spoj detection ver-alfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants