Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@kamildzierzak
Copy link
Member

@kamildzierzak kamildzierzak commented Aug 16, 2021

Closes #10

@vercel
Copy link

vercel bot commented Aug 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/73HyEFjnphPuj4oZL8Q3fue4YRM2
✅ Preview: https://coderscamp-website-git-issue-10-createsidebar-26b98d-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/nRxMHbFwM58DiJHXZsWqtwedU9CZ
✅ Preview: https://coderscamp-storybook-git-issue-10-createsideb-8c914e-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/AxdKvMb647ToVpQN3tDmxArnrw1g
✅ Preview: https://coderscamp-docs-git-issue-10-createsidebarand-6dbedb-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-10-cre-81sthz August 16, 2021 16:24 Inactive
@kamildzierzak kamildzierzak linked an issue Aug 16, 2021 that may be closed by this pull request
@kamildzierzak kamildzierzak changed the title add draft sidebar, sidebarItem and stories for them feat(ui): create Sidebar and SidebarItem components (#10) Aug 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #163 (ef2ee9a) into main (d9478f2) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   87.86%   87.80%   -0.06%     
==========================================
  Files         130      140      +10     
  Lines        1491     1591     +100     
  Branches      195      208      +13     
==========================================
+ Hits         1310     1397      +87     
- Misses        181      194      +13     
Flag Coverage Δ
api 85.14% <100.00%> (-0.33%) ⬇️
ui 99.01% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-registration-was-started.event-handler.service.ts 100.00% <ø> (ø)
packages/api/src/app.module.ts 100.00% <100.00%> (ø)
...confirmation-was-approved-event-handler.service.ts 100.00% <100.00%> (ø)
...en-complete-user-registration-automation.module.ts 100.00% <100.00%> (ø)
...ved-then-complete-user-registration.test-module.ts 100.00% <100.00%> (ø)
...en-request-email-confirmation-automation.module.ts 100.00% <100.00%> (ø)
...dule/shared/commands/complete-user-registration.ts 100.00% <100.00%> (ø)
...ts/user-registration-was-completed.domain-event.ts 100.00% <100.00%> (ø)
...ents/user-registration-was-started.domain-event.ts 100.00% <100.00%> (ø)
...tion/complete-user-registration.command-handler.ts 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4dd65...ef2ee9a. Read the comment docs.

Copy link
Member

@hoolek77 hoolek77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 The sidebar item with the icon is missing some margin-left. Rest looks good for me 👏🏻.

Copy link
Member

@hoolek77 hoolek77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✅

@kamildzierzak kamildzierzak merged commit eb40dd6 into main Sep 23, 2021
@kamildzierzak kamildzierzak deleted the issue-10-Create_Sidebar_and_SidebarItem_components branch September 23, 2021 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Sidebar and SidebarItem components

7 participants