Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@kamildzierzak
Copy link
Member

@kamildzierzak kamildzierzak commented Sep 30, 2021

Close #376

@vercel
Copy link

vercel bot commented Sep 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/CzTsjNqJG84qWv61QaYoopxessu1
✅ Preview: https://coderscamp-website-git-issue-376-maketheappea-6ed887-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/FhKY4iMjYKXFS6gCwPqDL4hfXMeC
✅ Preview: https://coderscamp-storybook-git-issue-376-maketheapp-f80da8-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/J6oLhTRHzJej6xUtGnMChxWghh3p
✅ Preview: https://coderscamp-docs-git-issue-376-maketheappearan-5d018c-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-376-ma-txcvge September 30, 2021 20:27 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #382 (6d391f8) into main (b21f090) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   88.01%   87.92%   -0.10%     
==========================================
  Files         148      150       +2     
  Lines        1661     1806     +145     
  Branches      213      236      +23     
==========================================
+ Hits         1462     1588     +126     
- Misses        198      217      +19     
  Partials        1        1              
Flag Coverage Δ
api 85.67% <ø> (+0.13%) ⬆️
ui 99.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...th/automation/user-registration-started.handler.ts 37.50% <0.00%> (-50.00%) ⬇️
...on/application/user-registration-emails.service.ts 75.00% <0.00%> (-25.00%) ⬇️
...ntation/rest/email-confirmation.rest-controller.ts 83.33% <0.00%> (-4.17%) ⬇️
...ation/application/register-user.command-handler.ts 96.00% <0.00%> (-4.00%) ⬇️
...ication/events-subscription/events-subscription.ts 94.33% <0.00%> (-2.05%) ⬇️
packages/api/src/shared/env.ts 100.00% <0.00%> (ø)
...ents-subscription/events-subscriptions-registry.ts 100.00% <0.00%> (ø)
.../api/src/crud/user-profile/user-profile.service.ts
...i/src/crud/user-profile/user-profile.repository.ts
...i/src/crud/user-profile/user-profile.controller.ts
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21f090...6d391f8. Read the comment docs.

@kamildzierzak kamildzierzak force-pushed the issue-376-Make_the_appearance_of_links_on_the_page_consistent branch from 28058b2 to 6d391f8 Compare September 30, 2021 20:35
@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-376-ma-txcvge September 30, 2021 20:35 Inactive
@kamildzierzak kamildzierzak added scope: 🌐 website Requires changes in the website workspace ⏱ 1 minute PR Really small pull request that probably can be reviewed under a minute 🦄 for design review PR should be reviewed by someone from the design team labels Sep 30, 2021
@kamildzierzak kamildzierzak marked this pull request as ready for review September 30, 2021 20:46
@kamildzierzak kamildzierzak merged commit 63d6b7d into main Nov 8, 2021
@kamildzierzak kamildzierzak deleted the issue-376-Make_the_appearance_of_links_on_the_page_consistent branch November 8, 2021 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🦄 for design review PR should be reviewed by someone from the design team scope: 🌐 website Requires changes in the website workspace ⏱ 1 minute PR Really small pull request that probably can be reviewed under a minute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the appearance of links on the page consistent.

7 participants