🐛 fix(ui): resolve #498 visual follow-ups#580
Merged
Conversation
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 22, 2026 11:44
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds preference-backed manual container grouping with a dialog, More-menu entry, grouping precedence, sanitization, and schema migration to version 12. Pinned newer tags now render as informational insights rather than “Up to date,” while same-tag digest changes are labeled “Image update.” Container column metadata and responsive hiding priorities are updated so Host remains visible ahead of Software Version. Documentation, localization, unit tests, and Playwright coverage are updated accordingly. Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/playwright/v16-modes-pins.spec.ts`:
- Around line 221-227: The table assertions target the container instead of the
tooltip-bearing nested span. In e2e/playwright/v16-modes-pins.spec.ts lines
221-227 and 288-294, update both assertion groups to use
tableState.locator('.font-semibold') for the text, negated text, and title
checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d6683de3-956e-49f0-9568-9a4ff18066f6
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!CHANGELOG.md
📒 Files selected for processing (46)
content/docs/current/api/index.mdxcontent/docs/current/configuration/actions/update-eligibility.mdxcontent/docs/current/configuration/dashboard/index.mdxcontent/docs/current/configuration/ui/index.mdxcontent/docs/current/configuration/watchers/index.mdxcontent/docs/current/faq/index.mdxcontent/docs/current/updates/index.mdxe2e/playwright/v16-mobile.spec.tse2e/playwright/v16-modes-pins.spec.tsui/src/components/containers/ContainerGroupDialog.vueui/src/components/containers/ContainersGroupedViews.vueui/src/components/containers/containersViewTemplateContext.tsui/src/composables/useColumnVisibility.tsui/src/composables/useUpdateStatus.tsui/src/locales/ar/dashboardView.jsonui/src/locales/de/dashboardView.jsonui/src/locales/en/containerComponents.jsonui/src/locales/en/containersView.jsonui/src/locales/en/dashboardView.jsonui/src/locales/es/dashboardView.jsonui/src/locales/fr/dashboardView.jsonui/src/locales/it/dashboardView.jsonui/src/locales/ja/dashboardView.jsonui/src/locales/ko/dashboardView.jsonui/src/locales/nl/dashboardView.jsonui/src/locales/pl/dashboardView.jsonui/src/locales/pt-BR/dashboardView.jsonui/src/locales/ru/dashboardView.jsonui/src/locales/tr/dashboardView.jsonui/src/locales/uk/dashboardView.jsonui/src/locales/vi/dashboardView.jsonui/src/locales/zh-CN/dashboardView.jsonui/src/locales/zh-TW/dashboardView.jsonui/src/preferences/migrate.tsui/src/preferences/schema.tsui/src/utils/update-kind-labels.tsui/src/views/ContainersView.vueui/tests/components/containers/ContainersGroupedViews.spec.tsui/tests/components/containers/UpdateStatusPanel.spec.tsui/tests/composables/useColumnVisibility.spec.tsui/tests/composables/useUpdateStatus.spec.tsui/tests/preferences/migrate.spec.tsui/tests/preferences/sync.spec.tsui/tests/utils/update-kind-labels.spec.tsui/tests/views/ContainersView.spec.tsui/tests/views/DashboardView.spec.ts
scttbnsn
force-pushed
the
fix/issue-498-visual-followups
branch
from
July 22, 2026 12:04
85de8fb to
dc2ad5e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/tests/components/containers/ContainersGroupedViews.spec.ts`:
- Around line 717-719: Update the test named “opens the manual group editor from
the row and card More menu” to either exercise the row More-menu path with a
table-mode assertion in addition to the existing card setup, or rename it to
accurately describe card-only coverage if row behavior is covered separately.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a30c471d-b047-471b-a4db-2a416b10b1de
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!CHANGELOG.md
📒 Files selected for processing (46)
content/docs/current/api/index.mdxcontent/docs/current/configuration/actions/update-eligibility.mdxcontent/docs/current/configuration/dashboard/index.mdxcontent/docs/current/configuration/ui/index.mdxcontent/docs/current/configuration/watchers/index.mdxcontent/docs/current/faq/index.mdxcontent/docs/current/updates/index.mdxe2e/playwright/v16-mobile.spec.tse2e/playwright/v16-modes-pins.spec.tsui/src/components/containers/ContainerGroupDialog.vueui/src/components/containers/ContainersGroupedViews.vueui/src/components/containers/containersViewTemplateContext.tsui/src/composables/useColumnVisibility.tsui/src/composables/useUpdateStatus.tsui/src/locales/ar/dashboardView.jsonui/src/locales/de/dashboardView.jsonui/src/locales/en/containerComponents.jsonui/src/locales/en/containersView.jsonui/src/locales/en/dashboardView.jsonui/src/locales/es/dashboardView.jsonui/src/locales/fr/dashboardView.jsonui/src/locales/it/dashboardView.jsonui/src/locales/ja/dashboardView.jsonui/src/locales/ko/dashboardView.jsonui/src/locales/nl/dashboardView.jsonui/src/locales/pl/dashboardView.jsonui/src/locales/pt-BR/dashboardView.jsonui/src/locales/ru/dashboardView.jsonui/src/locales/tr/dashboardView.jsonui/src/locales/uk/dashboardView.jsonui/src/locales/vi/dashboardView.jsonui/src/locales/zh-CN/dashboardView.jsonui/src/locales/zh-TW/dashboardView.jsonui/src/preferences/migrate.tsui/src/preferences/schema.tsui/src/utils/update-kind-labels.tsui/src/views/ContainersView.vueui/tests/components/containers/ContainersGroupedViews.spec.tsui/tests/components/containers/UpdateStatusPanel.spec.tsui/tests/composables/useColumnVisibility.spec.tsui/tests/composables/useUpdateStatus.spec.tsui/tests/preferences/migrate.spec.tsui/tests/preferences/sync.spec.tsui/tests/utils/update-kind-labels.spec.tsui/tests/views/ContainersView.spec.tsui/tests/views/DashboardView.spec.ts
🚧 Files skipped from review as they are similar to previous changes (41)
- ui/src/locales/zh-CN/dashboardView.json
- ui/src/locales/en/dashboardView.json
- ui/src/locales/ko/dashboardView.json
- ui/src/locales/ja/dashboardView.json
- ui/src/locales/uk/dashboardView.json
- ui/src/locales/vi/dashboardView.json
- ui/src/locales/pl/dashboardView.json
- ui/tests/preferences/sync.spec.ts
- ui/src/locales/fr/dashboardView.json
- ui/src/locales/es/dashboardView.json
- ui/src/locales/de/dashboardView.json
- ui/src/locales/nl/dashboardView.json
- ui/src/locales/zh-TW/dashboardView.json
- ui/src/utils/update-kind-labels.ts
- ui/src/locales/tr/dashboardView.json
- ui/tests/utils/update-kind-labels.spec.ts
- ui/src/locales/ar/dashboardView.json
- ui/src/locales/pt-BR/dashboardView.json
- ui/src/locales/en/containersView.json
- ui/src/locales/it/dashboardView.json
- content/docs/current/configuration/dashboard/index.mdx
- content/docs/current/updates/index.mdx
- ui/tests/composables/useUpdateStatus.spec.ts
- ui/src/locales/en/containerComponents.json
- e2e/playwright/v16-mobile.spec.ts
- ui/src/locales/ru/dashboardView.json
- ui/tests/views/DashboardView.spec.ts
- content/docs/current/api/index.mdx
- ui/src/composables/useUpdateStatus.ts
- ui/tests/components/containers/UpdateStatusPanel.spec.ts
- e2e/playwright/v16-modes-pins.spec.ts
- ui/src/components/containers/ContainerGroupDialog.vue
- content/docs/current/configuration/actions/update-eligibility.mdx
- content/docs/current/faq/index.mdx
- ui/tests/views/ContainersView.spec.ts
- ui/src/composables/useColumnVisibility.ts
- content/docs/current/configuration/watchers/index.mdx
- ui/src/views/ContainersView.vue
- ui/src/preferences/migrate.ts
- content/docs/current/configuration/ui/index.mdx
- ui/src/components/containers/ContainersGroupedViews.vue
biggest-littlest
previously approved these changes
Jul 22, 2026
biggest-littlest
left a comment
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
Reviewed the issue #498 resolution against the full report, regression coverage, production Compose E2E, and direct desktop/mobile visual QA. Approved for merge.
ALARGECOMPANY
previously approved these changes
Jul 22, 2026
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
Member
There was a problem hiding this comment.
Independent approval: issue #498 findings are resolved, documented, regression-tested, and visually verified in desktop and true mobile contexts.
scttbnsn
enabled auto-merge (squash)
July 22, 2026 12:17
scttbnsn
dismissed stale reviews from ALARGECOMPANY and biggest-littlest
via
July 22, 2026 12:48
b27e5e9
biggest-littlest
approved these changes
Jul 22, 2026
biggest-littlest
left a comment
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
Re-approved latest head b27e5e9 after the deterministic Cucumber assertion was corrected and the exact failed scenario passed locally against the real test stack.
ALARGECOMPANY
approved these changes
Jul 22, 2026
Merged
scttbnsn
added a commit
that referenced
this pull request
Jul 22, 2026
## Summary Prepare **v1.6.0-rc.4** from the latest `main`. rc.4 delta over rc.3: - **#580 issue #498 visual follow-ups** - informational pinned Major/Minor/Patch states, "Image update" vocabulary and explanation, Host-first constrained layout, explicit Software Version metadata, browser-managed grouping, docs, regression coverage, and desktop/mobile visual QA. - **#581 Cucumber reliability** - complete retained-run audit, exact build-artifact reuse, six-fixture readiness manifest, scenario state restoration, structured reports/diagnostics, no blanket Cucumber/Playwright retries, fail-closed remote fixture seeding, and the targeted health-refresh product/race fixes. - Release identity advanced across the changelog, README, website/demo, current docs, API examples, quickstart, and guard tests. ## Verification - 123/123 repository script tests - 45/45 workflow invariant tests - 44/44 website script tests - Full pre-push gate: 100% app/UI coverage, type-check, Biome, Qlty, and app/UI builds - Local prerelease precheck completed; its five unchecked "shipped in v1.6.0" Discussion follow-ups remain GA closeout actions and are not RC blockers After merge: verify exact-`main` CI Verify and Playwright, then dispatch `release-cut.yml` with `release_tag=v1.6.0-rc.4`. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Changelog ### 🔧 Changed - Prepared release identity for `v1.6.0-rc.4` across README, website/demo mocks, API documentation, Portwing examples, quickstart materials, and release updates. - Updated changelog comparison links and release identity guard tests for `v1.6.0-rc.4`. - Added release-gated Cucumber E2E failure-reporting highlights to the updates page. ## Concerns - Verify exact CI Verify and Playwright workflows after merge. - Post the five tracked Discussion replies against the published release candidate. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Closes #498
Changelog
🐛 Fixed
insightupdate status (no update CTA/actions for digest-only comparisons).insightstate (info tone + pinned summary) instead of incorrectly showing Up to date.🔧 Changed
container.updateInsightas the primary source for update label/color, with digest-kind special-casing for image-update tooltip behavior.ContainerGroupDialog.containers.manualGroupsmanual overrides are prioritized over detected/Docker grouping.containers.manualGroups: Record<identityKey, groupName>dashboardView.updateKind.digestand add/adjust image-update strings.✨ Added
ContainerGroupDialogVue component (modal with save/clear, trimming/normalization, and suggestion support).#498scenarios (including digest-level test data, pinned tooltip/title checks, Host-vs-Software-Version responsive assertions).#498pinned insight state, image-update labeling, grouped viewupdateInsightsourcing, and container grouping dialog + preference trimming behavior.Concerns / Issues to Address
digestlocale keys (UI + any translation fallback paths) are fully covered so runtime never shows missing-key placeholders.updateInsightpaths never enable update CTAs/actions across all update-eligibility flows and panel variants.containers.manualGroupsmigration/sanitization + sync across devices preserves valid overrides and correctly clears back to server/Docker grouping.