🐛 fix(ui): make Resources column optional#583
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Resources column is now user-hideable and remains visible by default through legacy preference migration. When hidden, resource shortcuts are rendered in the container row’s More actions menu if resource data exists; they are omitted when the column is visible. Unit, component, migration, and Playwright tests cover persistence, rendering, shortcut ordering, and reload behavior. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
biggest-littlest
left a comment
There was a problem hiding this comment.
Checked the preference migration, hidden-state fallback, and the browser coverage. Resource links stay reachable, the default remains unchanged, and the saved choice survives reload. Looks good.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/components/containers/ContainersGroupedViews.vue`:
- Line 97: Update the resourcesHidden computed state in
ContainersGroupedViews.vue so it only considers hiddenColumnKeys when the
effective view is table mode, including forced card reflow; in card mode, ensure
Resources remains hidden when More renders the shortcut section and avoid
treating picker state as rendering state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fbcf5f30-2973-40d8-84cd-4e808bca94a9
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!CHANGELOG.md
📒 Files selected for processing (8)
e2e/playwright/v16-modes-pins.spec.tsui/src/components/containers/ContainersGroupedViews.vueui/src/composables/useColumnVisibility.tsui/src/preferences/migrate.tsui/src/preferences/schema.tsui/tests/components/containers/ContainersGroupedViews.spec.tsui/tests/composables/useColumnVisibility.spec.tsui/tests/preferences/migrate.spec.ts
biggest-littlest
left a comment
There was a problem hiding this comment.
Re-reviewed the card-mode follow-up. The fallback is now table-only, explicit and forced card modes have regression coverage, and the packaged browser test covers the full switch. Approved.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/tests/components/containers/ContainersGroupedViews.spec.ts`:
- Around line 2560-2565: Strengthen both mode assertions in
ui/tests/components/containers/ContainersGroupedViews.spec.ts at lines 2560-2565
and 2595-2595 by asserting that the matching card’s
container-card-resource-actions wrapper contains container-quick-links. Keep the
existing checks that the More/actions menu is absent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8d90a76b-e4b9-4b8c-9073-d36cd1ce967d
📒 Files selected for processing (3)
e2e/playwright/v16-modes-pins.spec.tsui/src/components/containers/ContainersGroupedViews.vueui/tests/components/containers/ContainersGroupedViews.spec.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- ui/src/components/containers/ContainersGroupedViews.vue
- e2e/playwright/v16-modes-pins.spec.ts
biggest-littlest
left a comment
There was a problem hiding this comment.
Re-reviewed the final test follow-up. Both explicit card mode and real 500px forced reflow now assert the card-local quick links themselves, while retaining the no-duplicate More-menu checks. Approved.
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Validated the final Resources-column behavior and the strengthened card/reflow coverage on 77d047c. The user preference is preserved, actions remain reachable, and both card paths prove the links are not duplicated. Approved.
## Summary Prepare **v1.6.0-rc.5** from the latest `main`. rc.5 delta over rc.4: - **#583 issue #498 Resources follow-up** — Resources remains visible by default but is now user-hideable and persistent; Source, Release Notes, and Registry remain reachable from each table row's More menu, while cards keep the same links in their footer without duplication. Covered at the reporter's exact 1197px laptop width and at 390px mobile. - **Website security refresh** — Next.js 16.2.9 → 16.2.11 and React/React DOM 19.2.7 → 19.2.8 after nine newly disclosed Next.js advisories blocked the local Qlty gate. Added a pinned-version regression guard and rc.5 security notes. - **Release identity** — advanced the changelog, README, website/demo, current docs, API examples, quickstart, and release guard tests to rc.5. ## Verification - 125/125 repository script tests - 45/45 workflow invariant tests - 44/44 website script tests - `npm audit`: 0 vulnerabilities in the website workspace - Website production build: 348 pages generated on Next.js 16.2.11 - Live development smoke: homepage and `/docs/v1.6/updates` both returned 200 with rc.5 content present - Full pre-push gate: 100% app/UI coverage, type-check, Biome, Qlty, and app/UI builds - Local prerelease precheck completed; its five unchecked “shipped in v1.6.0” Discussion follow-ups remain GA closeout actions and are not RC blockers After merge: verify exact-`main` CI Verify and Playwright, then dispatch `release-cut.yml` with `release_tag=v1.6.0-rc.5`.
Summary
Verification
Addresses the remaining Resources-column feedback in #498.
Changelog
#498covering Resources-column hiding and ensuring row/card “More” menu resource shortcuts remain correct (including exactdata-testordering).dd-table-cols-v1migration to preserve “links/Resources” when already present, otherwise append it once for older users.Concerns
links/Resourcesis already present vs missing).