Skip to content

🔧 chore(release): prepare v1.6.0-rc.1 changelog entry - #199

Merged
scttbnsn merged 2 commits into
dev/v1.6from
release/1.6.0-rc.1-prep
Aug 5, 2026
Merged

🔧 chore(release): prepare v1.6.0-rc.1 changelog entry#199
scttbnsn merged 2 commits into
dev/v1.6from
release/1.6.0-rc.1-prep

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Promotes the [Unreleased] block to [1.6.0-rc.1] - 2026-08-05 with a release-candidate intro paragraph covering the full v1.6 roadmap (#149, #151, #152, #153, #148, #150), and adds a fresh empty [Unreleased] block above it, per RELEASING.md step 5.

Also fixes two spacing glitches merge resolutions left in the block: a missing blank line before ### Tests and a doubled blank line before [1.5.2].

Verified locally:

  • node scripts/extract-changelog-entry.mjs --version v1.6.0-rc.1 extracts a non-empty entry (the release-cut validation)
  • node --test scripts/release-metadata.test.mjs passes (stable metadata stays 1.5.2 until GA promotion)
  • govulncheck ./...: zero reachable vulnerabilities (pre-tag gate 3)

Next steps after this merges: sync main from dev/v1.6, cut v1.6.0-rc.1 via the release-cut workflow, then run the new tri-tool conformance matrix against the published rc.1 image as the pre-GA gate.

Changelog

  • 🐛 Fixed TestRequestIDGeneratorBatchesEntropyReads flakiness by stopping the background refill goroutine before deterministic pool refilling.
  • ✨ Added the v1.6.0-rc.1 changelog entry and release-candidate introduction.
  • 🔧 Added a new empty [Unreleased] section and corrected changelog spacing.
  • 🔧 Verified changelog extraction, release metadata tests, and govulncheck ./....

Concerns

  • Sync main before cutting v1.6.0-rc.1.
  • Run the tri-tool conformance matrix.
  • Confirm the race-detector verification covers 200 test runs.

- 📝 docs(changelog): promote [Unreleased] to [1.6.0-rc.1] - 2026-08-05 with a release-candidate intro covering the full v1.6 roadmap (#149 #151 #152 #153 #148 #150)
- 🎨 style(changelog): fix missing blank line before ### Tests and a doubled blank line before [1.5.2] introduced by merge resolutions
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sockguard-website Ready Ready Preview Aug 5, 2026 8:58pm

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8fc67855-838f-488c-a208-4a802b695d69

📥 Commits

Reviewing files that changed from the base of the PR and between 335bb52 and 0e4eafc.

⛔ Files ignored due to path filters (1)
  • CHANGELOG.md is excluded by !CHANGELOG.md
📒 Files selected for processing (1)
  • app/internal/logging/access_test.go

📝 Walkthrough

Walkthrough

The test now closes the request ID generator before calling refillSync. This stops the background refill goroutine before the test checks the deterministic entropy fill count. Deferred cleanup was replaced with immediate closure.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/1.6.0-rc.1-prep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The constructor queues an async refill signal, so the background goroutine's refillSync could race the test's manual refillSync — both passing the low-watermark guard before either enqueues, recording 2 entropy fills where the test expects 1 (seen on PR #199 CI). Stop the goroutine before filling so exactly one fill stocks the pool in every interleaving. Verified with -race -count=200.
@scttbnsn

scttbnsn commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@scttbnsn
scttbnsn merged commit 33b9405 into dev/v1.6 Aug 5, 2026
61 checks passed
@scttbnsn
scttbnsn deleted the release/1.6.0-rc.1-prep branch August 5, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant