🔧 chore(release): prepare v1.6.0-rc.1 changelog entry - #199
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test now closes the request ID generator before calling 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The constructor queues an async refill signal, so the background goroutine's refillSync could race the test's manual refillSync — both passing the low-watermark guard before either enqueues, recording 2 entropy fills where the test expects 1 (seen on PR #199 CI). Stop the goroutine before filling so exactly one fill stocks the pool in every interleaving. Verified with -race -count=200.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Promotes the
[Unreleased]block to[1.6.0-rc.1] - 2026-08-05with a release-candidate intro paragraph covering the full v1.6 roadmap (#149, #151, #152, #153, #148, #150), and adds a fresh empty[Unreleased]block above it, per RELEASING.md step 5.Also fixes two spacing glitches merge resolutions left in the block: a missing blank line before
### Testsand a doubled blank line before[1.5.2].Verified locally:
node scripts/extract-changelog-entry.mjs --version v1.6.0-rc.1extracts a non-empty entry (the release-cut validation)node --test scripts/release-metadata.test.mjspasses (stable metadata stays 1.5.2 until GA promotion)govulncheck ./...: zero reachable vulnerabilities (pre-tag gate 3)Next steps after this merges: sync
mainfromdev/v1.6, cutv1.6.0-rc.1via the release-cut workflow, then run the new tri-tool conformance matrix against the published rc.1 image as the pre-GA gate.Changelog
TestRequestIDGeneratorBatchesEntropyReadsflakiness by stopping the background refill goroutine before deterministic pool refilling.v1.6.0-rc.1changelog entry and release-candidate introduction.[Unreleased]section and corrected changelog spacing.govulncheck ./....Concerns
mainbefore cuttingv1.6.0-rc.1.