Skip to content

ci(gitleaks): allowlist the response-filter fixture secrets - #485

Merged
scttbnsn merged 1 commit into
dev/v2.1from
ci/gitleaks-allow-responsefilter-fixtures
Sep 6, 2026
Merged

ci(gitleaks): allowlist the response-filter fixture secrets#485
scttbnsn merged 1 commit into
dev/v2.1from
ci/gitleaks-allow-responsefilter-fixtures

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

The dev/v2.1 CI Verify run on 803888c failed only on Gitleaks: three generic-api-key hits, all in the test fixtures #482 added. Two are the base64 podman-secret payload the partial-decode differential uses to prove redaction still reaches SecretData, one is the s3cr3t-signing-key env value in the inspect benchmark body.

Both values are synthetic. This adds them to .gitleaks.toml the same way the swarm and seccomp fixtures are already handled: value and path both have to match, so the same strings anywhere else still fail the scan.

Verified locally with gitleaks detect --log-opts=origin/main..HEAD: no leaks found.

✨ Added Gitleaks allowlist entries for synthetic secrets in response-filter test fixtures.

🔒 Scoped each allowlist entry to its exact fixture path with condition = "AND":

  • podman-secret base64 payloads in app/internal/responsefilter/list_item_partial_decode_test.go

  • s3cr3t-signing-key in app/internal/responsefilter/perf_bench_test.go

  • Verify that both podman-secret payloads are explicitly allowlisted.

  • Confirm gitleaks detect --log-opts=origin/main..HEAD passes.

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sockguard-website Ready Ready Preview Sep 6, 2026 12:12pm UTC

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.

@ALARGECOMPANY ALARGECOMPANY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.

@scttbnsn
scttbnsn merged commit ea051d0 into dev/v2.1 Sep 6, 2026
57 of 60 checks passed
@scttbnsn
scttbnsn deleted the ci/gitleaks-allow-responsefilter-fixtures branch September 6, 2026 12:13
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 9e17d8ec-3c33-477c-9cde-a94a9d8a9331

📥 Commits

Reviewing files that changed from the base of the PR and between 803888c and 89db91c.

⛔ Files ignored due to path filters (1)
  • CHANGELOG.md is excluded by !CHANGELOG.md
📒 Files selected for processing (1)
  • .gitleaks.toml

📝 Walkthrough

Walkthrough

Added two gitleaks allowlist entries in .gitleaks.toml. Each entry uses condition = "AND" and limits the exception to one test file. The entries cover a synthetic base64 payload and a synthetic signing key.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/gitleaks-allow-responsefilter-fixtures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants