ci(gitleaks): allowlist the response-filter fixture secrets - #485
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
biggest-littlest
left a comment
There was a problem hiding this comment.
Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded two gitleaks allowlist entries in ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The dev/v2.1 CI Verify run on 803888c failed only on Gitleaks: three
generic-api-keyhits, all in the test fixtures #482 added. Two are the base64podman-secretpayload the partial-decode differential uses to prove redaction still reachesSecretData, one is thes3cr3t-signing-keyenv value in the inspect benchmark body.Both values are synthetic. This adds them to
.gitleaks.tomlthe same way the swarm and seccomp fixtures are already handled: value and path both have to match, so the same strings anywhere else still fail the scan.Verified locally with
gitleaks detect --log-opts=origin/main..HEAD: no leaks found.✨ Added Gitleaks allowlist entries for synthetic secrets in response-filter test fixtures.
🔒 Scoped each allowlist entry to its exact fixture path with
condition = "AND":podman-secretbase64 payloads inapp/internal/responsefilter/list_item_partial_decode_test.gos3cr3t-signing-keyinapp/internal/responsefilter/perf_bench_test.goVerify that both
podman-secretpayloads are explicitly allowlisted.Confirm
gitleaks detect --log-opts=origin/main..HEADpasses.