test(cmd): clear SOCKGUARD_* before asserting clean pre-validation stderr - #489
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
biggest-littlest
left a comment
There was a problem hiding this comment.
Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Reviewed against the CHANGELOG entry and the diff; CI green outside the qlty/Vercel quota noise.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe “validate before opening log output” test now calls ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The promotion PR's podman integration legs (rootful and rootless) both failed on one unit test:
TestRunServeErrorPaths/validate_before_opening_log_outputasserts nothing reaches stderr before validation, and the job exportsSOCKGUARD_TEST_PODMAN_SOCKET, which the new unknown-variable warning (#469) correctly reports before validation runs. The Go Test job has no such variable, so dev Verify was green.The validate-command tests already handle this with
clearSockguardEnv; this applies the same call to that subtest. Reproduced locally with the variable exported (fails before, passes after), and the wholeinternal/cmdpackage passes both with and without it set.Changelog
TestRunServeErrorPaths/validate_before_opening_log_outputby clearingSOCKGUARD_*variables withclearSockguardEnv(t)before the stderr assertion.SOCKGUARD_TEST_PODMAN_SOCKETin Podman integration jobs.