Update recommendations in extensions.json and enhance README for clar… #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity; fix typos in test assertions and update package versions in project file
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates package versions, fixes typos in test assertions, and enhances documentation by updating the README and extension recommendations.
- Bumps package versions for Microsoft.NET.Test.Sdk and NUnit.Analyzers
- Corrects multiple spelling mistakes in test assertions
- Updates README content and recommended extensions in VS Code configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| SanitizeFilenameTests/SanitizeFilenameTests.csproj | Updated package versions for test SDK and analyzers |
| SanitizeFilenameTests/FilenameTests/WindowsSpecificTests.cs | Renamed variable for clarity in Windows-specific tests |
| SanitizeFilenameTests/FilenameTests/SanitizeFilenamesTestsBase.cs | Removed extraneous whitespace header |
| SanitizeFilenameTests/FilenameTests/SanitizeFilenamesTests.cs | Fixed typo in .NET framework error message |
| SanitizeFilenameTests/FilenameTests/LinuxSpecificTests.cs | Fixed typo in .NET framework error message |
| SanitizeFilenameTests/DirectoryNameTests/SanitizeDirectoryNamesTests.cs | Fixed typos in test assertions for directory names |
| SanitizeFilenameTests/DirectoryNameTests/LinuxSpecificTests.cs | Fixed typo in .NET framework error message |
| README.md | Enhanced documentation with clearer OS indications and formatting improvements |
| .vscode/extensions.json | Revised extension recommendations by replacing one extension with an updated alternative |
| if (IsRunningOnNet4x()) | ||
| { | ||
| Assert.Pass("Test is not thought to be run with .net framwework / unicode 8"); | ||
| Assert.Pass("Test is not thought to be run with .net framework / unicode 8"); |
There was a problem hiding this comment.
The typo in '.net framwework' has been corrected to '.net framework'.
| if (IsRunningOnNet4x()) | ||
| { | ||
| Assert.Pass("Test is not thought to be run with .net framwework / unicode 8"); | ||
| Assert.Pass("Test is not thought to be run with .net framework / unicode 8"); |
There was a problem hiding this comment.
The typo in '.net framwework' has been corrected to '.net framework'.
| if (IsRunningOnNet4x()) | ||
| { | ||
| Assert.Pass("Test is not thought to be run with .net framwework / unicode 8"); | ||
| Assert.Pass("Test is not thought to be run with .net framework / unicode 8"); |
There was a problem hiding this comment.
Corrected spelling: '.net framwework' is now '.net framework'.
| if (IsRunningOnNet4x()) | ||
| { | ||
| Assert.Pass("Test is not thought to be run with .net framwework / unicode 8"); | ||
| Assert.Pass("Test is not thought to be run with .net framework / unicode 8"); |
There was a problem hiding this comment.
Corrected spelling: '.net framwework' is now '.net framework'.
| if (IsRunningOnNet4x()) | ||
| { | ||
| Assert.Pass("Test is not thought to be run with .net framwework / unicode 8"); | ||
| Assert.Pass("Test is not thought to be run with .net framework / unicode 8"); |
There was a problem hiding this comment.
Corrected spelling: '.net framwework' is now '.net framework'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ity; fix typos in test assertions and update package versions in project file