Skip to content

fix(ci): replace invalid job-level secrets gate with step-level gate in commercial-backup.yml#31

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
fix/commercial-backup-secrets-gate
Jul 21, 2026
Merged

fix(ci): replace invalid job-level secrets gate with step-level gate in commercial-backup.yml#31
Coding-Dev-Tools merged 1 commit into
mainfrom
fix/commercial-backup-secrets-gate

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

GitHub Actions does not support the secrets context in job-level if expressions, causing the workflow to fail every scheduled run. Replace with the same step-level gate pattern used in production-synthetics.yml: a dedicated gate step checks env vars and sets skip=true when secrets are unconfigured (pre-GA), with all subsequent steps conditioned on steps.gate.outputs.skip != 'true'.

…in commercial-backup.yml

GitHub Actions does not support the secrets context in job-level if
expressions, causing the workflow to fail every scheduled run. Replace
with the same step-level gate pattern used in production-synthetics.yml:
a dedicated gate step checks env vars and sets skip=true when secrets
are unconfigured (pre-GA), with all subsequent steps conditioned on
steps.gate.outputs.skip != 'true'.
@Coding-Dev-Tools
Coding-Dev-Tools merged commit 53e79a8 into main Jul 21, 2026
8 checks passed
@Coding-Dev-Tools
Coding-Dev-Tools deleted the fix/commercial-backup-secrets-gate branch July 21, 2026 00:47
@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

Pre-PR Review — APPROVE

Verdict: APPROVE

Analysis

This PR correctly replaces the invalid job-level if: ${{ secrets.ENGRAPHIS_CUSTOMER_URL != '' }} gate (which GitHub Actions evaluates as an empty string in if expressions, causing the job to always fail) with a proper step-level gate that checks all four required secrets and sets a skip output.

Verification

  • CI: 7/8 checks pass (docker build correctly skips — no Dockerfile changes)
  • The fix is minimal, correct, and follows GitHub Actions best practices
  • No security concerns — secrets are checked for presence only, never exposed
  • The ::warning:: annotation provides clear visibility when secrets are missing

Hermes Pre-PR Reviewer — 2026-07-21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant