fix(ci): replace invalid job-level secrets gate with step-level gate in commercial-backup.yml#31
Merged
Conversation
…in commercial-backup.yml GitHub Actions does not support the secrets context in job-level if expressions, causing the workflow to fail every scheduled run. Replace with the same step-level gate pattern used in production-synthetics.yml: a dedicated gate step checks env vars and sets skip=true when secrets are unconfigured (pre-GA), with all subsequent steps conditioned on steps.gate.outputs.skip != 'true'.
Owner
Author
Pre-PR Review — APPROVEVerdict: APPROVE AnalysisThis PR correctly replaces the invalid job-level Verification
Hermes Pre-PR Reviewer — 2026-07-21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions does not support the
secretscontext in job-levelifexpressions, causing the workflow to fail every scheduled run. Replace with the same step-level gate pattern used inproduction-synthetics.yml: a dedicated gate step checks env vars and setsskip=truewhen secrets are unconfigured (pre-GA), with all subsequent steps conditioned onsteps.gate.outputs.skip != 'true'.