Make the v1.0.1 CodeQL gate repository-wide#65
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebdc23b026
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf4a155d64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
ENGRAPHIS_INDEX_ROOTSpolicyWhy
PR #64 eliminated findings in its changed ranges, but the main-branch scan exposed 47 repository-wide results because CodeQL pull-request analysis was diff-informed. The first truly full PR scan then exposed 56 raw Python results, including downstream path and exception flows that the diff scan had omitted. This branch fixes those findings and the gate that allowed them to remain hidden.
The weak-hash result traced from a test variable named
secretthat held a non-secret receipt-exclusion marker into the compatibility feature mapper. The test now names that value accurately; the non-security feature hash remains byte-identical and keeps native performance.Verification
python -m pytest tests/ -q— full suite passedruff check .— cleangit diff --check— cleanThe required hosted proof is a clean full CodeQL run on this PR followed by a clean
mainrun after merge.