Skip to content

No rules for logs or installers, so two categories are unreachable #51

Description

@Muawiya-contact

Category has ten variants. base.json produces four of them — system_critical, browser_cache, build_artifact, package_manager_cache, temp_file. No rule ever yields log or installer, so those two are unreachable, and the app has labels sitting in CATEGORY_LABEL for categories that can't appear.

empty_directory can't ever appear either, but for a different reason: the scanner skips everything that isn't a file, so directories never enter the report at all. That one probably needs its own issue.

Good place to start if you want to contribute rules — docs/RULES.md has the format and the guidelines. Candidates:

  • logs: /var/log/, ~/Library/Logs/, %LOCALAPPDATA%\...\Logs
  • installers: .msi, .dmg, .pkg, .exe sitting in Downloads

Keep them conservative — review rather than safe unless removal genuinely can't cost anything.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is neededrulesThe safety rules database

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions