Fix: trigger preview deploy on ready_for_review#264
Merged
Conversation
The deploy-preview job has an `if: draft == false` guard, but the workflow only listened for opened/synchronize/reopened events. When a PR was created as draft and later marked ready, no new workflow run was triggered, so the deploy was permanently skipped. Adding `ready_for_review` to the event types fixes this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR preview deploy GitHub Actions workflow so a preview deployment is triggered when a draft PR is marked “Ready for review”, preventing permanently-skipped preview deploys for PRs that start as drafts.
Changes:
- Adds the
ready_for_reviewevent type to thepull_requestworkflow trigger. - Ensures the existing
draft == falsejob condition can be re-evaluated on the ready-for-review transition.
saeb-cognigy
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-previewjob guards ondraft == false, but the workflow only triggered onopened,synchronize, andreopenedeventsready_for_reviewevent was not handled, so no workflow run was triggered and the deploy stayed permanently skipped (e.g. PR Update deperecated packages #263)ready_for_reviewto thepull_requestevent types so the deploy runs when a draft PR is promotedTest plan