Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an accessibility landmark to the Webchat chat history container so assistive technologies can identify and navigate to the chat log as a named region.
Changes:
- Add
role="region"to the chat log container inChatScroller. - Keep labeling via existing
aria-labelledby="webchatChatHistoryHeading"to provide an accessible name without introducing implicit live-region behavior.
kwinto
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor accessibility improvement adding a
role="region"landmark to the chat log container (ChatScroller).role="log"was considered but rejected: that role impliesaria-live="polite"behaviour, causing screen readers to automatically announce every new message appended to the container. The Webchat already has a dedicatedScreenReaderLiveRegioncomponent (src/webchat-ui/components/presentational/ScreenReaderLiveRegion.tsx) that manages live announcements witharia-live="polite". Usingrole="log"on the scroll container would duplicate those announcements and create a noisy, unpredictable screen reader experience. Addingaria-live="off"to suppress the implicit live behaviour ofrole="log"was also considered, but browser and screen reader support for overriding a role's implicitaria-livevalue is inconsistent — some screen readers ignore the override and announce anyway. On the other hand,role="region"gives the area a named landmark without implying any live-region behaviour.Success criteria
webchatChatHistoryHeadingelementHow to test
webchatChatHistoryHeadingSecurity
Additional considerations