test(coro): stabilize task group completion regression#1005
Merged
Conversation
Coldwings
force-pushed
the
fix/ci-task-group-test-placement
branch
from
July 21, 2026 23:14
d34920d to
8be290e
Compare
Coldwings
force-pushed
the
fix/ci-task-group-test-placement
branch
from
July 21, 2026 23:21
8be290e to
001f516
Compare
Owner
Author
|
Independent static review completed for exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the task_group completion-order regression establish deterministic worker placement before it pauses child completion. The inner owner coroutine explicitly migrates to worker 0, and the child explicitly migrates to worker 1 before it is allowed to fail.
Type of Change
Related Issues
Closes #1003
Changes Made
Core Changes
API Changes (if applicable)
None.
Migration Guide (if breaking change)
Not applicable.
Testing
Unit Tests
Integration Tests
Sanitizer Testing
Test Results
Local compilation was intentionally not performed. The patch passed git diff --check; GitHub Actions provides executable x64/arm64 and sanitizer validation.
Checklist
Code Quality
Documentation
Testing
Compatibility
Performance
Screenshots / Diagrams
Not applicable.
Additional Notes
The original failure was caused by a test hook blocking whichever worker happened to run the child while an externally scheduled owner continuation could land in that same worker inbox. No production task_group behavior is changed.
Reviewer Guidance
Areas requiring special attention: