docs(runtime): explain shutdown requirements for service loops - #1014
Merged
Conversation
Owner
Author
|
Independent read-only review summary:
Verdict: no blocking objections remain for the reviewed head. |
Coldwings
force-pushed
the
docs/scheduler-shutdown-service-loops
branch
from
July 28, 2026 10:05
6cb7aeb to
0274403
Compare
Owner
Author
|
Independent read-only re-review summary for the rebased head:
Verdict: no blocking objections remain for the rebased head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents that graceful scheduler shutdown drains accepted work but does not
request application-level accept loops, periodic timers, or other service tasks
to stop.
Callers must cancel or wake those loops and await them before an unbounded
shutdown, or use a finite timeout and accept force-stop semantics.
Type of Change
Related Issues
Closes #1010
Changes Made
Core Changes
scheduler::shutdown()header contract with service-loop guidance.API Changes (if applicable)
No signature or runtime behavior changes. This PR documents the existing
contract.
Testing
Unit Tests
Integration Tests
Sanitizer Testing
Test Results
This documentation-only change was not compiled or tested locally. GitHub
Actions provides executable validation.
Checklist
Code Quality
Documentation
Testing
Compatibility
Performance (if applicable)
Reviewer Guidance
Areas requiring special attention: