Resolve settings viewport before first client render - #1792
Conversation
Terraform Validation Results
Pushed by: @open-inspect[bot], Action: |
There was a problem hiding this comment.
Deep review
Two blocking design issues remain. The hydration replacement changes fresh client-navigation behavior on mobile, and the warning-key change still does not provide a unique identity even though the persistence layer already has one. No changed file crosses 1,000 lines; the largest resulting source file is 471 lines.
This is submitted as a comment review rather than REQUEST_CHANGES because the authenticated GitHub App is also the pull request author, and GitHub does not permit authors to request changes on their own pull requests.
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
ColeMurray
left a comment
There was a problem hiding this comment.
Reviewed exact head 0aad072, final settings/media-query implementation and tests, existing consumers, and all review threads. Both findings are addressed and resolved: fresh mobile navigation uses the real viewport immediately without mounting desktop content, and speculative warning-key changes were removed. Controlled baseline/original-PR comparisons demonstrate the actual rendering benefit. Twenty-five focused tests, real SSR hydration, shared build, web typecheck and scoped lint/format passed. All final-head CI is green with intentional Terraform deployment skips. No remaining blockers.
Summary
Review feedback addressed
Validation
@open-inspect/sharedand passed web typecheck.git diff --checkpassed.renderToString/hydrateRoottest preserves the server busy placeholder, renders only the mobile child tree after hydration, and reports no recoverable hydration errors.mount, update(the busy placeholder adds a commit). With this change it records onlymount.The prior React Doctor diagnostic counts are not claimed for this narrowed revision. CI must pass on the final head before merge.