fix(types): validate cached JSON and webhook filters - #1817
Conversation
Terraform Validation Results
Pushed by: @open-inspect[bot], Action: |
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
ColeMurray
left a comment
There was a problem hiding this comment.
Reviewed exact head 076a30c, all changed files, cache adapters/consumers, webhook configuration compatibility and all discussion. Follow-up retains existing persisted filter/editor behavior, replaces assertions with compatible explicit scalar coercions, and repairs regression fixtures so they genuinely exercise cache validation. The unknown-return cache boundary remains useful on main. Shared/cache/workerd tests passed (34 + 45 + 15, one intentional clock skip), as did full workspace typecheck and lint/format. All applicable exact-head CI is green; Terraform deployment jobs intentionally skipped. No actionable comments or remaining blockers.
This is an automated nightly unsafe-cast remediation sweep, updated after review to preserve existing webhook configuration and editor behavior.
Changes
CacheStore, its Cloudflare KV adapter, andSqlCacheStorereturnunknowninstead of a caller-selected generic type.Number/Stringcoercion while preserving the existing scalar filter schema and JavaScript comparison semantics. Existing numeric-string comparisons and numericcontainsvalues remain accepted, including configurations emitted by the current editor.Verification
npm run typecheckpassed, including control-plane unit/integration/Node configurations, all bots, infrastructure packages, shared, and web.076a30cfb8970f4ec4f79a5e1f9c53c8d1a58d24, including both integration shards and Compose smoke; Terraform Plan/Apply are intentionally skipped for PR validation.mainwithout conflicts; no dependency changes are introduced by this PR.Created with Open-Inspect