Develop - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all composed launch files and their documentation from the repository. Composed launch files previously allowed the system to be started under a single process for improved performance, but at the cost of more difficult debugging and fault tolerance. The documentation and launch files for non-generative, generative, and generative with perception configurations have all been deleted.
The most important changes are:
Removal of composed launch files:
fabric_server/launch/nongenerative.launch.py, which provided a composed launch for Fabric Server and Capabilities2 Server for non-generative use.fabric_server/launch/generative.launch.py, which provided a composed launch for Fabric Server, Capabilities2 Server, and prompt_tools for generative use without perception.fabric_server/launch/generative_perception.launch.py, which provided a composed launch for Fabric Server, Capabilities2 Server, prompt_tools, and Perception Server for generative use with perception.Documentation updates:
README.md, including instructions and explanations for using composed launch files in various configurations.