[EMERGENCY HOTFIX] Preview - 1.83.1 Sophon Incident #740
Conversation
neon-nyan
added
Bug
There was a problem hiding this comment.
Pull Request Overview
This PR provides an emergency hotfix to update launcher functionality after the removal of Zip packages from the launcher APIs, moving dependencies for various features entirely to Sophon as a game file reference. Key changes include updating download links and version numbers in the README, modifying repair and manifest-fetching logic to support Sophon assets, and refactoring language and patch handling in the installation components.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated download links and build versions to reflect the new release. |
| Hi3Helper.* | Updated subproject commits for Sophon and EncTool dependencies. |
| Hi3Helper.Core/.../GameDataStructure.cs | Enabled nullable context around new properties. |
| Hi3Helper.Core/.../ClassesContext.cs | Extended JSON source-generation options with a new ignore condition. |
| CollapseLauncher.csproj | Bumped version from 1.83.0 to 1.83.1. |
| Repair.cs, GenshinRepair.cs | Modified repair handling to utilize Sophon for asset downloads. |
| Fetch.cs | Refactored manifest fetching and asset elimination logic to support Sophon and audio file processing. |
| Check.cs | Adjusted hash comparison conditions for file validation. |
| GenshinInstall.PkgVersion.cs | Added support for generating a fake pkg_version from Sophon manifest data. |
| InstallManagerBase.cs, InstallManagerBase.SophonPatch.cs, InstallManagerBase.PkgVersion.cs | Refactored language string methods and enhanced pkg_version download and patch manifest processing. |
Comments suppressed due to low confidence (2)
CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.PkgVersion.cs:187
- [nitpick] Consider rephrasing the error message for clarity, for example: 'The audio language index file was expected at {path} but was not found.'
throw new FileNotFoundException("Game does have audio lang index file but does not exist! Expecting location: {_gameAudioLangListPathStatic}");
CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs:550
- The condition for setting remoteUrl was changed from checking for non-patch assets to checking when isPatch is true; please confirm that this inversion is intentional.
if (!string.IsNullOrEmpty(secondaryParentURL) && manifestEntry.isPatch)
bagusnl
left a comment
bagusnl
left a comment
There was a problem hiding this comment.
All is good, just a bit off-ed by the early global pragma but I think we can discuss that
But overall the code looks fine, pretty sure @copilot can fix the typos so its all fine
Good work!
CollapseLauncher/Classes/InstallManagement/Base/InstallManagerBase.cs
Outdated
Show resolved
Hide resolved
|
Regarding FOSSA failing check: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
100% reviewed source file: 'en_US.json' on 'es_419'.
|
Main Goal
As per May 5th 2025 (on Genshin Impact 5.6 update), HoYo just removed the entire Zip packages from the launcher APIs. causing a major issue throughout Third-party Launcher Community (Collapse is no exception). This PR also fixed some essential features which has stopped working due its dependency on Zip's ScatteredFiles references. Now, all those features are moving its dependency entirely to Sophon as its game files references.
What's changed?
versionfield inconfig.iniwith 2-numbers or less format.PR Status :