Move individual to their respective group

[tarunnjoshi]

Move individual to their respective group for contribution page

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced enhanced event handling for chapter group assignments related to contributions.
  • Added a method to assign chapter groups when a contribution is created.

• Bug Fixes

  • Improved error handling for chapter group retrieval based on state ID.

• Style

  • Adjusted styling for buttons and form elements to improve layout and responsiveness.
  • Enhanced media queries for better display on various screen sizes.

These updates enhance user experience and streamline contribution processing within the Goonj CRM.

[coderabbitai]

Walkthrough

The changes in this pull request primarily enhance the functionality of the CollectionCampService class in the Civi namespace by introducing new event handling capabilities and improving chapter group assignments related to contributions. Additionally, there are significant updates to the styling in the main.scss and style.css files, focusing on layout adjustments, responsiveness, and visual consistency across various components.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php	- Added method: assignChapterGroupToIndividualForContribution for handling contributions. - Updated method: assignChapterGroupToIndividual to streamline group assignment logic. - Added private method: getChapterGroupForState for retrieving chapter groups based on state ID.
wp-content/themes/goonj-crm/assets/styles/main.scss	- Adjusted styles for .wp-block-gb-action-button and .wp-block-gb-goonj-blocks for improved layout and responsiveness. - Modified media queries for better display on various screen sizes.
wp-content/themes/goonj-crm/style.css	- Extensive modifications to form styles, including layout changes and responsive design adjustments. - Standardized input field styles and button appearances for consistency.

Possibly related PRs

• Change mmt to frontend #274: Modifies the CollectionCampService class, related to event handling and email notifications.
• Fix the sharable link #313: Changes in the CollectionCampService class regarding URL generation and email notifications.
• Change the type of custom field #319: Updates URL parameters in the CollectionCampService, relevant to event handling.
• bug fixes and refactor #329: Introduces new methods in CollectionCampService for email notifications.
• Refactor CollectionCampService.php and DroppingCenterService.php #352: Refactors CollectionCampService, enhancing its functionality.
• Collection Camp Authorisation Status #362: Adds methods for managing camp statuses in CollectionCampService.
• Update Email Content #411: Modifies tab configurations and data handling in CollectionCampService.
• Integrate donation with Goonj flows #437: Integrates donation functionality with CollectionCampService, relating to contributions.

Suggested reviewers

• pokhiii: Suggested for review due to familiarity with the CollectionCampService class.

Poem

In the land of code where changes bloom,
New methods sprout, dispelling the gloom.
Contributions now find their rightful place,
As styles dance with a responsive grace.
From classes to buttons, all align,
A harmonious update, oh how divine! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (3)

wp-content/themes/goonj-crm/assets/styles/main.scss (1)

507-507: Consider adjusting the padding for better usability.

The reduction in padding for .wp-block-gb-action-button might compromise the button's usability on mobile devices by reducing the clickable area. While maintaining a sleek design is important, ensuring that interactive elements are easily clickable on all devices is crucial.

wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (2)

Line range hint 309-331: Enhance error handling in getChapterGroupForState method

The method getChapterGroupForState logs a message when no chapter group is found for a state ID and attempts to retrieve a fallback group. However, if no fallback group is found, it doesn't handle the case where $stateContactGroup remains NULL, which could lead to unexpected behavior.

Consider adding error handling to manage the scenario when neither a chapter group nor a fallback group is available. This will prevent potential NULL reference errors.

Apply this diff to address the issue:

@@ -319,6 +319,10 @@
           \Civi::log()->info('Assigning fallback chapter contact group: ' . $stateContactGroup['title']);
         }
 
+        if (!$stateContactGroup) {
+          \Civi::log()->error('No fallback chapter contact group found.');
+          return NULL;
+        }
 
         return $stateContactGroup ? $stateContactGroup['id'] : NULL;
       }

---

52-52: Maintain consistency in event subscription ordering

The new event handler assignChapterGroupToIndividualForContribution is added to the &hook_civicrm_post array at line 52. Ensure that the ordering of event handlers considers dependencies between methods. If assignChapterGroupToIndividualForContribution depends on any prior methods, adjust the order accordingly for correct execution.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 701562c and cc0fda1.

📒 Files selected for processing (3)

• wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (4 hunks)
• wp-content/themes/goonj-crm/assets/styles/main.scss (1 hunks)
• wp-content/themes/goonj-crm/style.css (1 hunks)

🧰 Additional context used

🪛 Biome

wp-content/themes/goonj-crm/style.css

[error] 15-15: Unexpected shorthand property background after background-image

(lint/suspicious/noShorthandPropertyOverrides)

---

[error] 15-15: Unexpected shorthand property text-decoration after text-decoration-thickness

(lint/suspicious/noShorthandPropertyOverrides)

🔇 Additional comments (2)

wp-content/themes/goonj-crm/assets/styles/main.scss (1)

507-507: Good adjustments to responsiveness!

The modifications within the media queries, particularly for .wp-block-gb-goonj-blocks, .container, and .wp-block-gb-table, are well-thought-out. These changes enhance the layout's adaptability across different screen sizes, improving the overall user experience by ensuring that elements are appropriately scaled and spaced.

wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (1)

9-9: Unnecessary import if not used

The use Civi\Api4\Address; statement is added at line 9. Verify that all imported classes are utilized in the code. Unused imports can clutter the codebase and may lead to confusion.

If the Address class is indeed used in the new methods, this import is appropriate. Otherwise, consider removing it.

[coderabbitai]

⚠️ Potential issue

Potential issue with shorthand property overrides

The static analysis tool flagged potential issues with shorthand property overrides for background and text-decoration. These properties might be unintentionally overridden by other shorthand declarations, which could lead to unexpected visual results.

Here's a suggestion to address this:

- background-image:none !important;
+ background: none !important; /* Ensures no shorthand property overrides */
- text-decoration:none !important;
+ text-decoration: none !important; /* Ensures no shorthand property overrides */

Please verify and adjust accordingly to ensure the intended styles are applied without conflicts.

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Biome

[error] 15-15: Unexpected shorthand property background after background-image

(lint/suspicious/noShorthandPropertyOverrides)

---

[error] 15-15: Unexpected shorthand property text-decoration after text-decoration-thickness

(lint/suspicious/noShorthandPropertyOverrides)

[coderabbitai]

🛠️ Refactor suggestion

Refactor duplicate code in chapter group assignment methods

The methods assignChapterGroupToIndividual (lines 260-269) and assignChapterGroupToIndividualForContribution (lines 271-305) contain similar logic for assigning chapter groups to individuals based on state IDs. To adhere to the DRY (Don't Repeat Yourself) principle and improve maintainability, consider extracting the shared code into a separate private method.

Also applies to: 271-305

[coderabbitai]

⚠️ Potential issue

Incorrect usage of self::$individualId in contribution assignment

In assignChapterGroupToIndividualForContribution, the variable self::$individualId may not be set or may not correspond to the contact associated with the contribution. This could lead to incorrect assignment of the chapter group to the wrong individual. Instead, use $contactId, which is obtained from $objectRef->contact_id.

Apply this diff to fix the issue:

@@ -279,7 +279,7 @@
 
-        if (self::$individualId !== $objectRef->contact_id || !$objectRef->contact_id) {
+        if (!$objectRef->contact_id) {
           return FALSE;
         }
 
@@ -298,4 +298,4 @@
               ->addValue('contact_id', self::$individualId)
+              ->addValue('contact_id', $contactId)
               ->addValue('group_id', $groupId)
               ->addValue('status', 'Added')

Also applies to: 298-301