Conversation
WalkthroughThe changes in this pull request modify the URL construction within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| $homeUrl = \CRM_Utils_System::baseCMSURL(); | ||
| // Construct the full URLs for the forms. | ||
| $campVehicleDispatchFormUrl = $homeUrl . 'camp-vehicle-dispatch-form/#?Camp_Vehicle_Dispatch.Collection_Camp_Intent_Id=' . $collectionCampId . '&Camp_Vehicle_Dispatch.Filled_by=' . $campAttendedById . '&Camp_Vehicle_Dispatch.To_which_PU_Center_material_is_being_sent=' . $collectionCampGoonjOffice . '&Eck_Collection_Camp1=' . $collectionCampId; | ||
| $campVehicleDispatchFormUrl = $homeUrl . 'camp-vehicle-dispatch-form/#?Camp_Vehicle_Dispatch.Collection_Camp=' . $collectionCampId . '&Camp_Vehicle_Dispatch.Filled_by=' . $campAttendedById . '&Camp_Vehicle_Dispatch.To_which_PU_Center_material_is_being_sent=' . $collectionCampGoonjOffice . '&Eck_Collection_Camp1=' . $collectionCampId; |
There was a problem hiding this comment.
💡 Codebase verification
Issues Found: Old parameter name Camp_Vehicle_Dispatch.Collection_Camp_Intent_Id is still in use.
Please address the following instances to ensure consistency across the codebase:
wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.phpwp-content/civi-extensions/goonjcustom/CRM/Goonjcustom/Form/CollectionCampLinks.php
Ensure that all references to Camp_Vehicle_Dispatch.Collection_Camp_Intent_Id are updated to Camp_Vehicle_Dispatch.Collection_Camp.
🔗 Analysis chain
LGTM! Verify form compatibility and update documentation.
The change from Camp_Vehicle_Dispatch.Collection_Camp_Intent_Id to Camp_Vehicle_Dispatch.Collection_Camp aligns with the PR objective to update the custom field type. The new parameter name is more generic and appropriate.
Please ensure that:
- The Camp Vehicle Dispatch form can correctly process the new
Collection_Campparameter. - Any related documentation or user guides referencing the old parameter name are updated.
To verify the change across the codebase, you can run:
This will help identify any other places where the old parameter name might still be in use.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining instances of the old parameter name
rg "Camp_Vehicle_Dispatch\.Collection_Camp_Intent_Id" --type php
Length of output: 1271
2 participants
Change the type of custom field
Need to update things on staging and production
Add a new custom type on production which is an entity type for collection camp
Update the Camp Vehicle Dispatch Form where we need to remove the intent id and add the collection camp is
Here is the URL: https://goonj.test/camp-vehicle-dispatch-form/#?Camp_Vehicle_Dispatch.Collection_Camp=177&Camp_Vehicle_Dispatch.Filled_by=14920&Camp_Vehicle_Dispatch.To_which_PU_Center_material_is_being_sent=2700&Eck_Collection_Camp1=177
Changes on the Acknowlegde formbuilder and change it on the searchKit too to show the collection camp code and address
https://goonj.test/acknowledgement-form-for-logistics/#?Eck_Collection_Source_Vehicle_Dispatch1=33&Camp_Vehicle_Dispatch.Collection_Camp=177&id=33&Eck_Collection_Camp1=177
Remove the collection camp code and title from ack formbuilder
Remove the intent id from the Camp Vehicle Dispatch Data seatchKit
Check the update form on backend as well:
Update Camp Vehicle Dispatch Data for images searchkit link
wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fvehicle-dispatch-images#?Eck_Collection_Source_Vehicle_Dispatch1=[id]&Camp_Vehicle_Dispatch.Collection_Camp_Intent_Id=[Camp_Vehicle_Dispatch.Collection_Camp]&id=[id]
Main Issue = fix the Camp Vehicle Dispatch Data formbuilder id from the filters
https://goonj-crm.staging.coloredcow.com/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fafform#/edit/afsearchCampVehicleDispatchData
Fix the Vehicle Dispatch Images formbuilder id intent id
https://goonj-crm.staging.coloredcow.com/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fafform#/edit/afsearchVehicleDispatchImages
Fix the Acknowledgement For Logistics Data
https://goonj-crm.staging.coloredcow.com/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fadmin%2Fafform#/edit/afsearchAcknowledgementForLogisticsData
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation