Skip to content

Updated the form URL for acknowledgment and email sending to MMT#520

Merged
belwalshubham merged 1 commit intodevelopfrom
feat/fix-mmt-url
Dec 2, 2024
Merged

Updated the form URL for acknowledgment and email sending to MMT#520
belwalshubham merged 1 commit intodevelopfrom
feat/fix-mmt-url

Conversation

@belwalshubham
Copy link
Copy Markdown
Collaborator

@belwalshubham belwalshubham commented Dec 2, 2024

Description

  1. Updated the ack. form url

Summary by CodeRabbit

  • New Features

    • Enhanced email notifications with more specific URL parameters for collection camps.
    • Added relevant camp information to the outcome emails.
  • Bug Fixes

    • Improved error handling for adding contacts to groups, ensuring better logging of actions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the InstitutionCollectionCampService class, focusing on the URL generation and email handling for collection camps. Key changes include an updated method signature for sendEmailToMmt, which alters how parameters are passed, and the addition of a new query parameter in the sendOutcomeEmail method. The error handling in the addContactToGroup method remains unchanged. Overall, the adjustments refine the data specificity in URLs and enhance the information included in email communications.

Changes

File Path Change Summary
wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php - Updated method signature for sendEmailToMmt.
- Added new query parameter in sendOutcomeEmail.
- Maintained error handling in addContactToGroup.

Possibly related PRs

Suggested labels

status : ready for review

Suggested reviewers

  • tarunnjoshi
  • nishant22029

🎉 In the code where emails flow,
URLs now shine with a brighter glow.
Camp IDs precise, no more a mess,
Sending info that’s sure to impress!
With each change, we aim to delight,
Making sure our emails are just right! ✉️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ce27fc1 and a6c49f0.

📒 Files selected for processing (1)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@belwalshubham belwalshubham self-assigned this Dec 2, 2024
@belwalshubham belwalshubham merged commit 25a32b6 into develop Dec 2, 2024
@belwalshubham belwalshubham deleted the feat/fix-mmt-url branch December 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant