Fix(*) continue loop if contact not found

[nishant22029]

• Added fix to continue loop if contact not found

Summary by CodeRabbit

• New Features

  • Enhanced email handling logic for induction activities, allowing for better processing of follow-up emails.
  • Improved status updates for induction activities to accurately reflect 'No_show' conditions.

• Bug Fixes

  • Enhanced error handling for email notifications, providing better visibility into issues.

• Refactor

  • General code cleanup for improved clarity and maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications to the InductionService class within Civi/InductionService.php. Key updates include changes to email handling logic, allowing for continued processing when no contacts are found, and refined status updates for induction activities. Error handling improvements have been made to enhance debugging capabilities, along with general code cleanup for clarity. These changes aim to improve the robustness of the induction process, particularly in managing email notifications and activity statuses.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/Civi/InductionService.php	- Modified sendInductionRescheduleEmail to continue processing when no contacts are found. - Updated sendFollowUpEmails to allow the loop to proceed without exiting prematurely. - Refined status updates to 'No_show' for induction activities. - Enhanced error handling in sendRemainderEmails with improved logging. - General code cleanup for clarity.

Possibly related PRs

• Fix/queue induction email #342: Modifies the InductionService class to enhance email handling capabilities.
• Added cron to update induction status and send followup email #415: Introduces cron jobs that utilize the sendFollowUpEmails method.
• fix(*) update API query #421: Updates the sendFollowUpEmails method, directly related to the current changes.
• Fix(*) update induction status no show  #428: Adds the updateInductionStatusNoShow method for managing induction activity statuses.
• Add Cron to send Reschedule email volunteer induction status is not Visited #459: Introduces a new method for sending reschedule emails, directly related to the current changes.
• Fix(*) Followup cron contact not found  #486: Enhances the sendInductionRescheduleEmail method, indicating a direct relationship.
• Removed Debugging Logs #488: Includes updates to the sendFollowUpEmails method, showing a connection in handling follow-ups.
• Removed single function while fetching contact details #544: Modifies the sendInductionRescheduleEmail method, directly related to email handling logic.

Suggested reviewers

• tarunnjoshi
• belwalshubham

🎉 In the land of code, where logic flows,
The InductionService now gracefully grows.
Emails reschedule, statuses align,
With clearer paths, the process will shine.
Errors logged, no more to hide,
In this code's journey, we take great pride! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 56f12a1 and 1d1bd13.

📒 Files selected for processing (1)

• wp-content/civi-extensions/goonjcustom/Civi/InductionService.php (3 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.