Skip to content

Feat/conditionally remove tabs from contact summary#625

Merged
tarunnjoshi merged 5 commits intodevelopfrom
feat/conditionally-remove-tabs-from-contact-summary
Dec 14, 2024
Merged

Feat/conditionally remove tabs from contact summary#625
tarunnjoshi merged 5 commits intodevelopfrom
feat/conditionally-remove-tabs-from-contact-summary

Conversation

@pokhiii
Copy link
Copy Markdown
Member

@pokhiii pokhiii commented Dec 14, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new class for managing contact summary views, allowing for dynamic tab visibility based on user permissions.
    • Added methods for sending logistics and volunteer feedback emails related to Goonj activities.
    • Implemented a follow-up email system for unscheduled induction activities.
  • Bug Fixes

    • Enhanced error handling and logging for email sending processes.
    • Improved checks and conditions for activity creation and email notifications in various services.
  • Improvements

    • Refined logging practices and error handling in payment processing and cancellation methods.
    • Updated methods to ensure better management of activity statuses and email communications.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces modifications across multiple CiviCRM extension files, focusing on enhancing email notifications, activity handling, and permission-based tab management. The changes span four different service classes: Razorpay Payment, Contact Summary View, Goonj Activities, Induction, and Institution Goonj Activities. The modifications primarily involve adding new methods for email sending, improving error handling, and refining activity processing logic.

Changes

File Change Summary
wp-content/civi-extensions/civirazorpay/.../Razorpay.php - Removed logging in processOneTimePayment method
- Enhanced doCancelRecurring method with property checks and error handling
wp-content/civi-extensions/goonjcustom/Civi/ContactSummaryViewService.php - Added new class for managing contact summary view tabs
- Implemented tab hiding based on user permissions
wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php - Added methods for sending logistics and volunteer feedback emails
- Implemented HTML email content generation methods
wp-content/civi-extensions/goonjcustom/Civi/InductionService.php - Added sendFollowUpEmails method for processing unscheduled induction activities
- Added updateInductionStatusNoShow method for managing induction statuses
wp-content/civi-extensions/goonjcustom/Civi/InstitutionGoonjActivitiesService.php - Removed unused import statements
- Updated methods with improved error handling and activity creation logic

Suggested labels

status : ready for review

Suggested reviewers

  • belwalshubham

Poem

🚀 Code flows like a river's might,
Extensions dancing in digital light,
Emails sent, tabs hidden with care,
Permissions checked everywhere,
A symphony of logic, pure and bright! 🌟

Possibly related PRs

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0916508 and 9a161e7.

📒 Files selected for processing (5)
  • wp-content/civi-extensions/civirazorpay/CRM/Core/Civirazorpay/Payment/Razorpay.php (0 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/ContactSummaryViewService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php (0 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InductionService.php (2 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionGoonjActivitiesService.php (11 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pokhiii pokhiii force-pushed the feat/conditionally-remove-tabs-from-contact-summary branch from dfa1f3d to 54ad165 Compare December 14, 2024 10:19
@tarunnjoshi tarunnjoshi marked this pull request as ready for review December 14, 2024 12:42
@tarunnjoshi tarunnjoshi merged commit 9fff7a9 into develop Dec 14, 2024
@tarunnjoshi tarunnjoshi deleted the feat/conditionally-remove-tabs-from-contact-summary branch December 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants