Fix end date in volunteer feedback cron for goonj activities

[nishant22029]

• updated goonj activities end date in volunteer feedback cron

Summary by CodeRabbit

• Bug Fixes

  • Updated error handling to improve logging for collection camp processing.

• Improvements

  • Adjusted filtering criteria for collection camps based on end dates, enhancing the accuracy of camp selection.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the query logic in the civicrm_api3_goonjcustom_volunteer_feedback_goonj_activity_cron function by changing the filtering condition for collection camps from Collection_Camp_Intent_Details.End_Date to Goonj_Activities.End_Date. This adjustment impacts the selection criteria for collection camps retrieved via the EckEntity API. Additionally, error handling within the foreach loop has been updated to include specific logging messages that incorporate the camp ID, though the variable used for logging is not defined, which may lead to an undefined variable notice.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/VolunteerFeedbackGoonjActivityCron.php	Modified filtering condition for collection camps and updated error logging mechanism.

Possibly related PRs

• Updated Mail Id for Collection Camp #300: Modifications to CollectionCampCron.php, related to handling collection camps.
• Seperate the cron for feedback and logistics #309: Changes to CollectionCampCron.php, focusing on logic for handling collection camps.
• Change the type of custom field #319: Updates to CollectionCampCron.php, affecting handling of collection camp identifiers.
• bug fixes and refactor #329: Modifications to CollectionCampCron.php, relevant to processing of collection camps.
• Collection Camp Authorisation Status #362: Updates to CollectionCampService.php, related to handling collection camps and their statuses.
• Update Contributor And Contribution Count #522: Introduces methods in InstitutionCollectionCampService.php for updating contributor counts, connecting to handling of collection camps.
• Send Institution Feedback Cron #515: Involves sending feedback emails related to institution camps, connecting to feedback handling.

Suggested labels

status : ready for review

Suggested reviewers

• tarunnjoshi

🎉 In the code, a change was made,
To filter camps in a new parade.
With logging now more clear,
But a variable's still unclear!
Let's fix the bugs, and then we'll cheer,
For cleaner code, let's persevere! 🎊

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e6fefae and 64e0872.

📒 Files selected for processing (1)

• wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/VolunteerFeedbackGoonjActivityCron.php (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.