BEHAVIOR: use Ruff rule names, not codes - #677
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676
❗ Behavioral changes
check-dev-filesnow identifies rules by name instead of by code, both in[tool.ruff.lint] ignoreand in[tool.ruff.lint.per-file-ignores]—any-typeinstead ofANN401,undocumented-public-moduleinstead ofD100,private-member-accessinstead ofSLF001, and so on. Prefix selectors that have no single rule name (ANN,D,DOC,FBT,PTH,T20, …) remain as codes.preview = trueto[tool.ruff], so downstream repositories need no extra opt-in, but a repository that disables preview will now fail withInvalid selector.docs/conf.pyis now grantedbuiltin-variable-shadowingon top ofundocumented-public-module, so Sphinx'scopyright = ...assignment no longer needs an inline suppression.pyproject.tomlare merged rather than rewritten, so those configurations will list both the old code and the new name until the codes are pruned by hand.Squash commit messages