Skip to content

Refactor rotation logic#238

Merged
Hgamo merged 1 commit intomainfrom
233-rotate-shifts-forward-objective-has-logic-flaws
Jan 12, 2026
Merged

Refactor rotation logic#238
Hgamo merged 1 commit intomainfrom
233-rotate-shifts-forward-objective-has-logic-flaws

Conversation

@Hgamo
Copy link
Collaborator

@Hgamo Hgamo commented Jan 12, 2026

No description provided.

@Hgamo Hgamo linked an issue Jan 12, 2026 that may be closed by this pull request
@CarryHof
Copy link
Collaborator

you forgot to consider special shifts

Copy link
Collaborator

@CarryHof CarryHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

Copy link
Collaborator

@CarryHof CarryHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Hgamo Hgamo merged commit 0a44c5f into main Jan 12, 2026
1 check passed
@Hgamo Hgamo deleted the 233-rotate-shifts-forward-objective-has-logic-flaws branch January 12, 2026 16:51
Hgamo added a commit that referenced this pull request Jan 14, 2026
* Refactor rotation logic (#238)

* Add EverySecondWeekendFreeConstraint and remove objective implementation (#239)

* Add EverySecondWeekendFreeConstraint and remove objective implementation

* Remove EverySecondWeekendFreeObjective from constraints and test cases

* Refactor MaximizeEmployeeWishesObjective (#240)

Refactor MaximizeEmployeeWishesObjective to simplify penalty handling by directly appending variables and removing unnecessary penalty variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rotate-shifts-forward objective has logic flaws

2 participants