Skip to content

Feature/use replay subject - #42

Merged
twittemb merged 6 commits into
mainfrom
feature/use-replay-subject
Jun 1, 2021
Merged

Feature/use replay subject#42
twittemb merged 6 commits into
mainfrom
feature/use-replay-subject

Conversation

@twittemb

@twittemb twittemb commented Jun 1, 2021

Copy link
Copy Markdown
Member

Description

This PR replaces the usage of CurrentValueSubject to a ReplaySubject that does not need subscribe(on:) to handle the reentrancy.

Checklist

  • [*] this PR is based on the main branch and is up-to-date, if not please rebase your branch on the top of main
  • [*] the commits inside this PR have explicit commit messages
  • [*] unit tests cover the new feature or the bug fix
  • [*] the feature is documented in the README.md if it makes sense
  • [*] the CHANGELOG is up-to-date

@twittemb twittemb self-assigned this Jun 1, 2021
@twittemb
twittemb merged commit c9cb61f into main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant